Repository navigation
Pay fixes (SWML + cXML) - #833
Open
hey-august wants to merge 5 commits into
Open
hey-august wants to merge 5 commits into
hey-august wants to merge 5 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the cXML
<Pay>and SWMLpayreference pages in line with the platform, verified against the platform and the API spec. Tokenization is the main fix: the pages now say plainly that the connector'stoken_idcomes back asPaymentToken/pay_payment_results.payment_token.cXML
<Pay>ProfileId(never sent), describedPaymentTokenandPaymentConfirmationCodeprecisely, rewrote the broken<Note>, and added a "Tokenize a card end to end" example.actionparameters: renamed to what's sent (PayResult,PaymentCardExpirationDate,PaymentCardSecurityCode,PaymentErrorCode,PaymentConnectorError), and addedPaymentConnectorErrorCodeandBankAccountType.chargeAmount(string, notamount) andparameters(an array of single-key objects), and used an unmasked test card in the example.statusCallback: completed theForvalues, merged the duplicate events table into them, and noted thatpayment-completedis also sent for declines.minPostalCodeLengthandsecurityCodeare optional (defaults0/true), andpaymentConnectorUrlmust be HTTPS.</Pay>,<Prompt name=→for=, and garbled characters.SWML
payparameterswas missing from the request body.params.fornow lists its values, with the samepayment-completedcaveat.Spec
pay/main.tsp: the doc links now point to/docs/swml/reference/calling/pay. The regenerated output changes only those two links.Notes for reviewers
PaymentToken/payment_tokendescriptions describe intended behavior. A platform fix that returnstoken_idthere is approved but not yet deployed.paymentConnectorUrl, the undocumentedbankAccountType/voiceattributes and ACH connector fields, and legacy heading styles.Preview:
/docs/compatibility-api/cxml/reference/voice/pay/docs/swml/reference/calling/payType of Change
Related Issues
Closes #832
See also: signalwire/cloud-product#21804
Testing
Checklist