Skip to content

Simplify verification tooling and drop stale paths - #78

Merged
simonjohansson merged 1 commit into
mainfrom
cleanup-verification-tooling
Oct 22, 2026
Merged

simonjohansson merged 1 commit into
mainfrom
cleanup-verification-tooling

Conversation

@simonjohansson

Copy link
Copy Markdown
Owner

Summary

Implements the cleanup in #71: removes abandoned experiment code, makes verification reports describe the current engine, and reduces duplicated build and drawing code. Sound, calibration, machine ID 42 and saved meanings are unchanged.

  • Finding 1: remove oversampling factors, halfband/decimation responses, refinement comparisons and MODELDIGI_OVERSAMPLE from the checker and cost tools.
  • Finding 2: modulation rows keep the committed timing as committed_timing. measured_timing and the console drift line appear only when this run re-derived phases from the retained recordings.
  • Finding 3: delete dsp/dsp.c, dsp/dsp.h and tests/test_dsp.c.
  • Finding 4: the instance-independence test compares two fresh banks.
  • Finding 5: measure.py owns building, loading and calling the driver; equivalence.py and profile.py reuse it.
  • Finding 9 (text parts): fix the README MIX bullet and the architecture note. mod.json was already done in 052553c. The artwork stays open, as agreed.
  • Finding 10: range labels use fw_textf/fw_font5, centred for the font's 2-column apostrophe.
  • Finding 11: new cost scenario "most edges (Analog on)".
  • Finding 12: capture analysis rejects Analog on; a missing field is reported as not recorded.
  • Finding 13: CI runs mise run test:oscillators --modulation once.
  • Finding 14: drop redundant "$@", fix the tuning.s comment, and replace the Analog off-harmonic figures with measurements.

Verification

  • mise run test: pass. The new instance test fails with a shared-seed mutation (instances, line 138) and passes normally.
  • mise run test:oscillators --modulation: 13 unit tests plus 35 shape, 5 saw-level, 98 spectral, 15 frequency and 48 slow-modulation cases pass. No timing line is printed.
  • MODELDIGI_REFERENCE_DIR=… mise run test:reference --modulation: 35 local recordings, 48 re-derived source phases and 48 modulation cases pass. The timing line is printed from fresh measurements.
  • mise run cost, cost:equivalence and cost:profile --blocks 4: all pass. The new scenario's worst block is 76,966 cycles, 154% of the one-instance budget. The overrun is tracked in Keep the render reserve at the highest edge rates #74 and is not fixed here. The assembly matches C in every sample and state, including the new scenario, and the mutation is detected. The profile's attribution and image checks pass.
  • mise run firmware:digitakt builds and lints. test:firmware:controls passes on the built image, and I compared all six range positions in emulator screenshots against an earlier run. Labels keep the same box and centring; the stock font's digits differ slightly in shape.
  • analyse:device:oscillator on the retained osc1-waves and osc1-levels captures still passes and reports analog: not recorded.

Not run: hardware. The README screen captures (modeldigi-osc.png, control map) still show the previous glyph shapes.

🤖 Generated with Claude Code

Remove the 48 kHz engine's leftover oversampling machinery: rate
factors, halfband responses and refinement comparisons in the
oscillator checker, and the unused oversampling define in the cost
tools. Delete the silent DSP scaffold that only its own test called.

Report modulation timing drift only when this run measured it against
the retained recordings; committed timing is kept as labelled
provenance. Make the instance-independence test compare two fresh
banks, so a shared seed fails it.

Let the equivalence and profile tools build and run the driver through
the cost module, and add the most-edges workload (three tri/saws at
the 20 kHz clamp with the deepest feedback, Analog on) so the reported
worst case is the actual one. Reject device captures whose decoded
parameters show Analog on.

Draw range labels with the stock 3 x 5 font, centred for its narrow
apostrophe. Run the portable checks once in CI, drop redundant "$@"
from mise tasks, and correct stale descriptions and the Analog
off-harmonic figures.

#71

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@simonjohansson
simonjohansson merged commit c64f995 into main Oct 22, 2026
2 checks passed
@simonjohansson
simonjohansson deleted the cleanup-verification-tooling branch October 22, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant