Repository navigation
Simplify verification tooling and drop stale paths - #78
Merged
Merged
Conversation
Remove the 48 kHz engine's leftover oversampling machinery: rate factors, halfband responses and refinement comparisons in the oscillator checker, and the unused oversampling define in the cost tools. Delete the silent DSP scaffold that only its own test called. Report modulation timing drift only when this run measured it against the retained recordings; committed timing is kept as labelled provenance. Make the instance-independence test compare two fresh banks, so a shared seed fails it. Let the equivalence and profile tools build and run the driver through the cost module, and add the most-edges workload (three tri/saws at the 20 kHz clamp with the deepest feedback, Analog on) so the reported worst case is the actual one. Reject device captures whose decoded parameters show Analog on. Draw range labels with the stock 3 x 5 font, centred for its narrow apostrophe. Run the portable checks once in CI, drop redundant "$@" from mise tasks, and correct stale descriptions and the Analog off-harmonic figures. #71 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the cleanup in #71: removes abandoned experiment code, makes verification reports describe the current engine, and reduces duplicated build and drawing code. Sound, calibration, machine ID 42 and saved meanings are unchanged.
MODELDIGI_OVERSAMPLEfrom the checker and cost tools.committed_timing.measured_timingand the console drift line appear only when this run re-derived phases from the retained recordings.dsp/dsp.c,dsp/dsp.handtests/test_dsp.c.measure.pyowns building, loading and calling the driver;equivalence.pyandprofile.pyreuse it.mod.jsonwas already done in052553c. The artwork stays open, as agreed.fw_textf/fw_font5, centred for the font's 2-column apostrophe.not recorded.mise run test:oscillators --modulationonce."$@", fix thetuning.scomment, and replace the Analog off-harmonic figures with measurements.Verification
mise run test: pass. The new instance test fails with a shared-seed mutation (instances, line 138) and passes normally.mise run test:oscillators --modulation: 13 unit tests plus 35 shape, 5 saw-level, 98 spectral, 15 frequency and 48 slow-modulation cases pass. No timing line is printed.MODELDIGI_REFERENCE_DIR=… mise run test:reference --modulation: 35 local recordings, 48 re-derived source phases and 48 modulation cases pass. The timing line is printed from fresh measurements.mise run cost,cost:equivalenceandcost:profile --blocks 4: all pass. The new scenario's worst block is 76,966 cycles, 154% of the one-instance budget. The overrun is tracked in Keep the render reserve at the highest edge rates #74 and is not fixed here. The assembly matches C in every sample and state, including the new scenario, and the mutation is detected. The profile's attribution and image checks pass.mise run firmware:digitaktbuilds and lints.test:firmware:controlspasses on the built image, and I compared all six range positions in emulator screenshots against an earlier run. Labels keep the same box and centring; the stock font's digits differ slightly in shape.analyse:device:oscillatoron the retainedosc1-wavesandosc1-levelscaptures still passes and reportsanalog: not recorded.Not run: hardware. The README screen captures (
modeldigi-osc.png, control map) still show the previous glyph shapes.🤖 Generated with Claude Code