Repository navigation
Share the FRQ3 range rule between text and tuning - #84
Merged
Merged
Conversation
This was referenced Oct 22, 2026
FRQ3's value text and its FUNC and fine tuning steps each read the stored CONTROL word with their own spelling of its offset. Both now ask one helper, which keeps following the stored value, as decided: the editor shows the sound as it is saved, not after locks and LFOs. #77 Co-Authored-By: Claude Opus 5.5 <[email protected]>
The emulator control test now points the LFO at CONTROL with full depth and a held note, waits for the voice's CONTROL to sit below and then above the threshold, and requires FUNC tuning to take the stored CONTROL-on steps both times. #77 Co-Authored-By: Claude Opus 5.5 <[email protected]>
simonjohansson
force-pushed
the
frq3-saved-control
branch
from
October 22, 2026 22:37
e78ebef to
73a9818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the code part of #77.
Summary
Decision: FRQ3's range text and tuning steps keep following the stored CONTROL value (the editing context), not the value after locks and LFOs.
modeldigi_osc3_free(sound)beside the decoder: one place for the slot-47 offset and the CONTROL threshold.0x14 + 2 * 47andsound[114]).No behavior change.
Verification
mise run testpasses, including the FRQ3 text test for CONTROL on (+700) and off (+3500), which now goes through the helpermise run build:digitaktbuilds and lintsmise run test:firmware:controls): with stored CONTROL on and the LFO holding the voice's CONTROL at 56 (off) and then 91 (on), FUNC tuning takes the narrow steps (64 → 92) both times. Screens show the narrow+700FRQ3 text under the LFO and+3495cwith CONTROL stored off.🤖 Generated with Claude Code