Skip to content

Share the FRQ3 range rule between text and tuning - #84

Merged
simonjohansson merged 2 commits into
mainfrom
frq3-saved-control
Oct 22, 2026
Merged

simonjohansson merged 2 commits into
mainfrom
frq3-saved-control

Conversation

@simonjohansson

@simonjohansson simonjohansson commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Resolves the code part of #77.

Summary

Decision: FRQ3's range text and tuning steps keep following the stored CONTROL value (the editing context), not the value after locks and LFOs.

  • New modeldigi_osc3_free(sound) beside the decoder: one place for the slot-47 offset and the CONTROL threshold.
  • The FRQ3 value text and the FUNC/fine tuning steps both use it in place of their own copies (0x14 + 2 * 47 and sound[114]).

No behavior change.

Verification

  • mise run test passes, including the FRQ3 text test for CONTROL on (+700) and off (+3500), which now goes through the helper
  • mise run build:digitakt builds and lints
  • Emulator check with an LFO on CONTROL (mise run test:firmware:controls): with stored CONTROL on and the LFO holding the voice's CONTROL at 56 (off) and then 91 (on), FUNC tuning takes the narrow steps (64 → 92) both times. Screens show the narrow +700 FRQ3 text under the LFO and +3495c with CONTROL stored off.

🤖 Generated with Claude Code

simonjohansson and others added 2 commits October 23, 2026 00:37
FRQ3's value text and its FUNC and fine tuning steps each read the
stored CONTROL word with their own spelling of its offset. Both now ask
one helper, which keeps following the stored value, as decided: the
editor shows the sound as it is saved, not after locks and LFOs.

#77

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The emulator control test now points the LFO at CONTROL with full depth
and a held note, waits for the voice's CONTROL to sit below and then
above the threshold, and requires FUNC tuning to take the stored
CONTROL-on steps both times.

#77

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@simonjohansson
simonjohansson merged commit c412bdf into main Oct 22, 2026
4 checks passed
@simonjohansson
simonjohansson deleted the frq3-saved-control branch October 22, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant