Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started when my rogue friend Arnodorian-The Golden Plains gave me some suggestions after seeing a simple rotation guide I made based on SimC. I noticed the logs differ a bit from SimC here, so I went through high-key logs.
Top Trickster players in high keys cast Goremaw's Bite right before Shadow Dance, while the APL only casts it inside Dance. This adds a pre-Dance Goremaw's Bite when Ancient Arts is not up. The in-Dance line stays as a fallback. Deathstalker is unaffected.
Why it helps: Goremaw's Bite applies Ancient Arts (same Shadow Techniques handling as a builder), and its +20% finisher debuff then covers the opening Secret Technique and its clones. Currently the burst Dance opens with Secret Technique and Goremaw's Bite comes after, so it misses the +20%.
Logs (+23/+24): in 165 of 273 casts, Goremaw's Bite was cast outside Dance and Dance followed within 3s. When cast without Ancient Arts, it applied Ancient Arts in 115 of 134 casts.
I first tried casting it before Dance even when Ancient Arts was already up, like most of the logs do. That lost 0.46% on DungeonSlice: the extra GCD delays Shadow Blades, and the adds despawn on a timer. Requiring Ancient Arts to be down avoids the extra GCD.
Results (target_error=0.1, latest midnight, with vs without this change):
If this is already planned for the 12.1.5 APL update, feel free to close this. Thanks to the SimC maintainers for all the work!