Skip to content

Refuse '/' in Call-ID and bound recording paths in rtpp_record_ctor #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arfa-21 wants to merge 2 commits into
base: master
Choose a base branch
from
+92 −9
Open

Refuse '/' in Call-ID and bound recording paths in rtpp_record_ctor #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d8bd2
Refuse '/' in Call-ID and bound recording paths in rtpp_record_ctor
arfa-21 Oct 28, 2026
3a06fce
recording/basic.badpath: exercise PATH_MAX limit on recording file names
sobomax Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions src/rtpp_record.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ rtpp_record_ctor(const struct rtpp_cfg *cfsp, const struct remote_copy_args *rap
struct rtpp_record_channel *rrc;
const char *sdir, *suffix1, *suffix2;
int rval, remote;
size_t len;
pcap_hdr_t pcap_hdr;

remote = (rname != NULL && strncmp("udp:", rname, 4) == 0) ? 1 : 0;
Expand Down Expand Up @@ -210,6 +211,13 @@ rtpp_record_ctor(const struct rtpp_cfg *cfsp, const struct remote_copy_args *rap
goto e2;
}

if (rname == NULL && (memchr(sp->call_id->s, '/', sp->call_id->len) != NULL ||
memchr(sp->from_tag_nmn->s, '/', sp->from_tag_nmn->len) != NULL)) {
RTPP_LOG(sp->log, RTPP_LOG_ERR, "call-id or from-tag contains '/', "
"refusing to use it in the recording file name");
goto e2;
}

if (cfsp->record_pcap != 0) {
rrc->mode = MODE_LOCAL_PCAP;
} else {
Expand All @@ -232,19 +240,29 @@ rtpp_record_ctor(const struct rtpp_cfg *cfsp, const struct remote_copy_args *rap
sdir = cfsp->sdir;
rrc->needspool = 1;
if (rname == NULL) {
sprintf(rrc->rpath, "%s/%.*s=%.*s%s%s", cfsp->rdir, (int)sp->call_id->len,
sp->call_id->s, (int)sp->from_tag_nmn->len, sp->from_tag_nmn->s,
suffix1, suffix2);
len = snprintf(rrc->rpath, sizeof(rrc->rpath), "%s/%.*s=%.*s%s%s",
cfsp->rdir, (int)sp->call_id->len, sp->call_id->s,
(int)sp->from_tag_nmn->len, sp->from_tag_nmn->s, suffix1, suffix2);
} else {
sprintf(rrc->rpath, "%s/%s%s", cfsp->rdir, rname, suffix2);
len = snprintf(rrc->rpath, sizeof(rrc->rpath), "%s/%s%s",
cfsp->rdir, rname, suffix2);
}
if (len >= sizeof(rrc->rpath)) {
RTPP_LOG(sp->log, RTPP_LOG_ERR, "recording file name is too long");
goto e2;
}
}
if (rname == NULL) {
sprintf(rrc->spath, "%s/%.*s=%.*s%s%s", sdir, (int)sp->call_id->len,
sp->call_id->s, (int)sp->from_tag_nmn->len, sp->from_tag_nmn->s,
suffix1, suffix2);
len = snprintf(rrc->spath, sizeof(rrc->spath), "%s/%.*s=%.*s%s%s",
sdir, (int)sp->call_id->len, sp->call_id->s,
(int)sp->from_tag_nmn->len, sp->from_tag_nmn->s, suffix1, suffix2);
} else {
sprintf(rrc->spath, "%s/%s%s", sdir, rname, suffix2);
len = snprintf(rrc->spath, sizeof(rrc->spath), "%s/%s%s", sdir, rname,
suffix2);
}
if (len >= sizeof(rrc->spath)) {
RTPP_LOG(sp->log, RTPP_LOG_ERR, "recording file name is too long");
goto e2;
}
rrc->fd = open(rrc->spath, O_WRONLY | O_CREAT | O_TRUNC, DEFFILEMODE);
if (rrc->fd == -1) {
Expand Down
2 changes: 1 addition & 1 deletion tests/recording/basic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ run_recording() {
report_rc ${RPTL_RC} "running basic.${stest}.rptl RPTL script"
}

SUB_TESTS="${SUB_TESTS:-"files singlefile singlefile_c stopall files_stophalf singlefile_stophalf remote remote_p"}"
SUB_TESTS="${SUB_TESTS:-"files singlefile singlefile_c stopall files_stophalf singlefile_stophalf remote remote_p badpath"}"

for stest in ${SUB_TESTS}
do
Expand Down
65 changes: 65 additions & 0 deletions tests/recording/basic.badpath.rptl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
# Call-ID is copied from SIP, where '/' is a legal character. Recording
# (R, Rs) must be refused rather than create files outside of the
# recording directory.
#
# Recording file name built from a Call-ID (R, Rs) or given explicitly
# (C, Cs) that does not fit into PATH_MAX must be refused as well, both
# for the spool (no -S) and for the final (-S) path.

.eval: 0 -> RES_OK
.eval: E50 -> RES_E50
.eval: E65 -> RES_E65
.eval: recording.%%SUBTEST%% -> WORK_BASE
.eval: ../%%WORK_BASE%%.rec. -> CALLID
.eval: %%RECORD_SPL_DIR%%/%%CALLID%%=from_tag_1 -> REC_BASE

.exec: mkdir -p %%RECORD_SPL_DIR%%
.exec: rm -f %%REC_BASE%%.*

# Longer than PATH_MAX on any supported platform, yet short enough for
# the commands carrying it to fit into the RTPP_CMD_BUFLEN.
.exec: printf '%4200s' '' | tr ' ' x -> LONG_NAME
.eval: %%WORK_BASE%%.long.%%LONG_NAME%% -> CALLID_LONG
.eval: %%WORK_BASE%%.short -> CALLID_SHORT

.eval: -d dbug -T60 -W60 -P -r %%RECORD_SPL_DIR%% -> RTPPROXY_ARGS
socket rtpp: stdio: %%RTPPROXY_ARGS%% -> %%WORK_BASE%%.rout

rtpp: U %%CALLID%% 127.0.0.1 12345 from_tag_1 -> validate_port(PORT_A)
rtpp: L %%CALLID%% 127.0.0.1 54321 from_tag_1 to_tag_1 -> validate_port(PORT_O)

rtpp: R %%CALLID%% to_tag_1 from_tag_1 -> str_compare(RES_E50)
rtpp: Rs %%CALLID%% to_tag_1 from_tag_1 -> str_compare(RES_E50)

rtpp: U %%CALLID_LONG%% 127.0.0.1 12345 from_tag_1 -> validate_port(_)
rtpp: L %%CALLID_LONG%% 127.0.0.1 54321 from_tag_1 to_tag_1 -> validate_port(_)
rtpp: R %%CALLID_LONG%% to_tag_1 from_tag_1 -> str_compare(RES_E50)
rtpp: Rs %%CALLID_LONG%% to_tag_1 from_tag_1 -> str_compare(RES_E50)

rtpp: U %%CALLID_SHORT%% 127.0.0.1 12345 from_tag_1 -> validate_port(_)
rtpp: L %%CALLID_SHORT%% 127.0.0.1 54321 from_tag_1 to_tag_1 -> validate_port(_)
rtpp: C %%CALLID_SHORT%% %%LONG_NAME%% to_tag_1 from_tag_1 -> str_compare(RES_E65)
rtpp: Cs %%CALLID_SHORT%% %%LONG_NAME%% to_tag_1 from_tag_1 -> str_compare(RES_E65)

.close: rtpp
.exec: for f in %%REC_BASE%%.*; do test ! -e "$f" || exit 1; done

.eval: -d dbug -T60 -W60 -P -r %%RECORD_DIR%% -S %%RECORD_SPL_DIR%% -> RTPPROXY_ARGS
socket rtpp: stdio: %%RTPPROXY_ARGS%% -> %%WORK_BASE%%.S.rout

rtpp: U %%CALLID_LONG%% 127.0.0.1 12345 from_tag_1 -> validate_port(_)
rtpp: L %%CALLID_LONG%% 127.0.0.1 54321 from_tag_1 to_tag_1 -> validate_port(_)
rtpp: R %%CALLID_LONG%% to_tag_1 from_tag_1 -> str_compare(RES_E50)
rtpp: Rs %%CALLID_LONG%% to_tag_1 from_tag_1 -> str_compare(RES_E50)

rtpp: U %%CALLID_SHORT%% 127.0.0.1 12345 from_tag_1 -> validate_port(_)
rtpp: L %%CALLID_SHORT%% 127.0.0.1 54321 from_tag_1 to_tag_1 -> validate_port(_)
rtpp: C %%CALLID_SHORT%% %%LONG_NAME%% to_tag_1 from_tag_1 -> str_compare(RES_E65)
rtpp: Cs %%CALLID_SHORT%% %%LONG_NAME%% to_tag_1 from_tag_1 -> str_compare(RES_E65)

# Sanity check: the same session still records fine with a sane name.
rtpp: Cs %%CALLID_SHORT%% %%WORK_BASE%%.ok.pcap to_tag_1 from_tag_1 -> str_compare(RES_OK)

.close: rtpp
.exec: test -e %%RECORD_DIR%%/%%WORK_BASE%%.ok.pcap
.exec: rm -f %%RECORD_DIR%%/%%WORK_BASE%%.ok.pcap
Loading