Repository navigation
fix(file-server): do not write media body for HEAD requests - #61
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HttpFileRangedContentStream.Convert(used by the default video/audio file converters) wrote the whole file to the response stream forHEADrequests without aRangeheader. The ranged branch already skipped the body forHEAD.HEADreturned 500 (ProtocolViolationException: bytes exceed Content-Length).HEADreturned 200 followed by the full body, breaking response framing on persistent/pipelined connections (RFC 9110 §9.3.2).Fix
Return right after setting status and headers (
Accept-Ranges,Content-Type,Content-Length) when the method isHEAD, without reading the file.Tests
Added
FileServerHeadOnMediaFileDoesNotWriteBody(both engines): pipelinesHEADon a 300000-byte.mp4and aGET, asserting 200,Content-Length: 300000and that the next response starts right after the HEAD headers. Fails before the fix on both engines.SISK_TEST_ENGINE=Default: 237 passed, 67 skipped, 0 failedSISK_TEST_ENGINE=Cadente: 299 passed, 6 skipped, 0 failed