Repository navigation
fix(monitoring): bound route key cardinality for unknown request methods - #63
Open
CypherPotato wants to merge 1 commit into
Open
CypherPotato wants to merge 1 commit into
CypherPotato wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard route key is built from the raw request method token. On
RouteMethod.Anyroutes every method token is accepted, so each distinct token creates a new route key. Once the 200 tracked route slots are filled, routes not seen yet are only reported under(other routes).Fix
TrackHttpRequestClosenow keeps the method in the key only for the methods known by the router (GET,POST,PUT,PATCH,DELETE,HEAD,OPTIONS,QUERY, ordinal match). Any other method is recorded asOTHER <path>. Keys for known methods are unchanged.Test
UseMonitoring_DoesNotTrackClientMethodTokensAsRoutessends 230 distinct methods to aMapAnyroute, thenGET /late, and checks that/monitoring/datalistsGET /lateandOTHER /anyand no client method tokens. It fails without the fix and passes with it.Note:
Sisk.Monitoring.Testsis not part of theRun testsworkflow (it only runstests/Sisk.Core); it was run locally.