Skip to content

Bugfix: Remove main-thread location services check for single-shot location fetches - #25

Merged
fhasse95 merged 3 commits into
skiptools:mainfrom
fhasse95:location-main-thread-warning
Oct 6, 2026
Merged

fhasse95 merged 3 commits into
skiptools:mainfrom
fhasse95:location-main-thread-warning

Conversation

@fhasse95

@fhasse95 fhasse95 commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

This PR removes the CLLocationManager.locationServicesEnabled() check introduced in #23 for single-shot location fetches because calling it on the main thread triggers a runtime warning: "This method can cause UI unresponsiveness if invoked on the main thread".

Removing this check also aligns the single-shot location fetching behavior with Android, where no equivalent check is performed before fetching a location.


Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@cla-bot cla-bot Bot added the cla-signed label Oct 5, 2026

@marcprux marcprux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge and tag a new patch release.

@fhasse95 fhasse95 changed the title Bugfix: Avoid main-thread location services check Bugfix: Remove main-thread location services check for single-shot location fetches Oct 6, 2026
@fhasse95
fhasse95 merged commit 1f29ae5 into skiptools:main Oct 6, 2026
2 of 3 checks passed
@fhasse95
fhasse95 deleted the location-main-thread-warning branch October 6, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants