Repository navigation
Bugfix: Remove main-thread location services check for single-shot location fetches - #25
Merged
Merged
Conversation
marcprux
approved these changes
Oct 6, 2026
marcprux
left a comment
Member
There was a problem hiding this comment.
Looks good! Feel free to merge and tag a new patch release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
CLLocationManager.locationServicesEnabled()check introduced in #23 for single-shot location fetches because calling it on the main thread triggers a runtime warning: "This method can cause UI unresponsiveness if invoked on the main thread".Removing this check also aligns the single-shot location fetching behavior with Android, where no equivalent check is performed before fetching a location.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift test