Repository navigation
Honor the passed schema for struct payloads (regression from 1.7.0) - #1426
Merged
mtdowling merged 1 commit intoOct 24, 2026
Merged
Conversation
PayloadSerializer.writeStruct took the MemberSubsetCodec fast path for any struct, serializing it with struct.schema() and dropping the schema it was given. 1.7.0 always serialized with the passed schema. Only take the fast path when the struct's schema is the target of the passed schema, matching the existing guards in HttpBindingSerializer.
adwsingh
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Describe the observable difference in behavior before and after this change.
Fixed a regression when http payload serializer serializes a struct with a passed schema being different from struct's
schema()one.Why is this change needed?
A fix of regression from 1.7.0 introduced in #1358. The same is being used in multiple other places, but not in payload serializer:
How was this validated?
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.