Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
wtn
force-pushed
the
path
branch
6 times, most recently
from
October 26, 2026 20:50
23787ff to
9e22a6d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23, fixes #110.
FilePartsized an IO without#lengthwithFile.size(io.local_path). That raisedENOENT ... local.pathfor IOs with#sizebut no path, such asDown::ChunkedIO(#110), andNoMethodErrorfor objects passed withoutUploadIO, such as Rails'ActionDispatch::Http::UploadedFile. It also measured the wrong file when the path no longer led to the open one: deleted after opening, relative after aDir.chdir, orTempfile.create(anonymous: true).FilePartnow uses#length, then#size, then the file atlocal_path, and raisesArgumentErrorwhen none gives a length, e.g. aDown::ChunkedIOwithout aContent-Length.UploadIOnow opens aPathnameas a filename.Pathnameresponds to#read, butPathname#read(length)always reads from the start of the file, so with#sizein use its uploads would never end.For Down users: with a gzip-encoded response,
ChunkedIO#sizeis the compressed length. Passingheaders: { "Accept-Encoding" => "identity" }toDown.openavoids this.Types of Changes
Contribution