Skip to content

Fix missing requires - #112

Open
wtn wants to merge 1 commit into
socketry:mainfrom
wtn:require
Open

wtn wants to merge 1 commit into
socketry:mainfrom
wtn:require

Conversation

@wtn

@wtn wtn commented Oct 26, 2026 •

Copy link
Copy Markdown
  • parts.rb uses CompositeReadIO but didn't require it, so calling FilePart.new after require 'multipart/post/parts' raised NameError.
  • multipart/post.rb didn't require version.rb, so Multipart::Post::VERSION was undefined. require 'multipart_post' had the same problem with MultipartPost::VERSION, which is all that file defined before 2.2.0.
  • parts_spec.rb and composite_read_io_spec.rb use UploadIO but didn't require it, so each failed when run alone.

parts_spec.rb no longer requires composite_read_io, so running it alone fails without the parts.rb fix. The full suite passes either way, since other spec files load composite_read_io first.

Types of Changes

  • Bug fix.
  • Maintenance.

Contribution

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wtn wtn changed the title Fix missing requires and move CompositeIO into its shim Fix missing requires Oct 26, 2026
@wtn
wtn marked this pull request as ready for review October 26, 2026 17:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant