Repository navigation
docs(pda-rent-payer): add caller authority check security note (#671) - #760
Open
khoap1220-hue wants to merge 1 commit into
Open
khoap1220-hue wants to merge 1 commit into
khoap1220-hue wants to merge 1 commit into
Conversation
…a-foundation#671) Add a security note across the Anchor, Native, and Pinocchio create_new_account instructions clarifying that the example omits a caller authority check for brevity.
Contributor
[Low impact] This documentation-only change appears safe to merge. SummaryAdds a security note above Anchor’s
Reviews (1) · Last reviewed commit: "docs(pda-rent-payer): add caller authori..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: trivial
Refs #671
Summary
SECURITY NOTEdoc comment abovecreate_new_account/process_create_new_accountacross all threebasics/pda-rent-payerimplementations (anchor,native, andpinocchio).rent_vaultPDA unless production code verifies an authorized signer and compares its key against a stored admin/funder pubkey (in addition to the general account validation checks shown inbasics/checking-accounts).AI disclosure
Tool and extent: Assisted in drafting the security note comment wording across the Anchor, Native, and Pinocchio examples; manually reviewed and verified against the program source files.