Skip to content

fix(install/pwsh): hide progress bar - #3921

Merged
rxri merged 4 commits into
spicetify:mainfrom
SchooiCodes:main
Oct 24, 2026
Merged

rxri merged 4 commits into
spicetify:mainfrom
SchooiCodes:main

Conversation

@SchooiCodes

@SchooiCodes SchooiCodes commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

$ProgressPreference = 'SilentlyContinue' hides the download status bar. For some unknown to me reason, that speeds up the download.. a lot.

I was testing with spicetify's installer, because I was working on a project, when I remembered (from experience) that this singular line ALWAYS speeds up network requests. So this is my humble attempt at a pull request :)

Check this out:

PS C:\Users\user\Documents\Github\cli> $time = Measure-Command {
>>     .\install.ps1 | Out-Default
>> }
>> $time
...                                                                                          
Days              : 0                                                                                                   
Hours             : 0                                                                                                   
Minutes           : 0                                                                                                   Seconds           : 13
Milliseconds      : 880
Ticks             : 138800085
TotalDays         : 0.000160648246527778
TotalHours        : 0.00385555791666667
TotalMinutes      : 0.231333475
TotalSeconds      : 13.8800085
TotalMilliseconds : 13880.0085
(with the line)

PS C:\Users\user\Documents\Github\cli> $time = Measure-Command {
>>     iwr -useb https://raw.githubusercontent.com/spicetify/cli/main/install.ps1 | iex | Out-Default
>> }
>> $time
...
Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 31
Milliseconds      : 300
Ticks             : 313003380
TotalDays         : 0.000362272430555556
TotalHours        : 0.00869453833333333
TotalMinutes      : 0.5216723
TotalSeconds      : 31.300338
TotalMilliseconds : 31300.338
(without the line)

Summary by CodeRabbit

  • User Experience
    • Installation runs without displaying download progress indicators.

`$ProgressPreference = 'SilentlyContinue'` hides the download status bar. For some unknown to me reason, that speeds up the download.. a lot.
@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3302b4fa-9dbe-48dc-89fd-2f5e24ddc671

📥 Commits

Reviewing files that changed from the base of the PR and between eaf1c27 and dafa714.

📒 Files selected for processing (1)
  • install.ps1

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The PowerShell installation script suppresses progress-bar output from web requests and downloads.

Changes: Installation output

Layer / File(s) Summary
Suppress installation progress output
install.ps1
Sets $ProgressPreference to SilentlyContinue during installation.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: rxri

Merge Risk: Minimal · up to dafa7

The installer retains its existing behavior while hiding nonessential progress output, so no merge-blocking risk is present.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(install/pwsh): hide progress bar" matches the only functional change in the changeset. The change adds $ProgressPreference = 'SilentlyContinue' to install.ps1, which hides the progres…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Title check

Explanation

The title "fix(install/pwsh): hide progress bar" matches the only functional change in the changeset. The change adds $ProgressPreference = 'SilentlyContinue' to install.ps1, which hides the progress bar during installation. The title is concise, specific, and follows a conventional-commit style. It does not describe the runtime reduction that the PR objectives cite, but the title names the primary change.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SchooiCodes SchooiCodes changed the title Added a SINGULAR line that halves script runtime. fix: Added a SINGULAR line that halves script runtime. Sep 6, 2026
@SchooiCodes SchooiCodes changed the title fix: Added a SINGULAR line that halves script runtime. fix: added a SINGULAR line that halves script runtime. Sep 6, 2026
@SchooiCodes

Copy link
Copy Markdown
Contributor Author

sorry for the title changes - i didn't know i needed a specific format to pass lint.

@SchooiCodes

Copy link
Copy Markdown
Contributor Author

hopefully this helps!

@SchooiCodes

Copy link
Copy Markdown
Contributor Author

..anyone?

@rxri rxri changed the title fix: added a SINGULAR line that halves script runtime. fix(install/pwsh): hide progress bar Oct 24, 2026
@rxri
rxri merged commit f4a824f into spicetify:main Oct 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants