machine: Disk.Cache goes; nothing sets it - #94
Merged
Merged
Conversation
No consumer sets a disk's cache mode (spin never has; #48 dropped the bench axis for that reason), and its own comment argued the default is right. Cache, cacheModes, their three validate cases and --disk-cache go; why the default is right moves to driveArg. A chain given a disk-level format is now asked of validate on its own. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
aledbf
force-pushed
the
machine/no-disk-cache
branch
from
October 2, 2026 00:07
19c4a64 to
8627155
Compare
aledbf
added a commit
that referenced
this pull request
Oct 2, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
aledbf
added a commit
that referenced
this pull request
Oct 2, 2026
* machine: the fingerprint is one hash, and Incoming one field identity() was split out so FingerprintCache could memoise the file sums alone; the cache is gone, and identity was a second length-prefixed writer whose output was hashed again. The shape, the topology and the host CPU are written into the fingerprint's hash directly. Every fingerprint changes with it: no checkpoint taken before this resumes after it. IncomingDefer and Incoming were two fields for -incoming's one argument, with a validate case to keep them apart. Incoming takes "defer", QEMU's own word, as the CLI already did. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> * machine: qemuOpt's comment names no cache mode, which #94 removed Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
machine.Disk.Cacheandspin-machine boot --disk-cachehad no setter: spin never sets it, no Taskfile, workflow or probe passes the flag, and #48 already dropped the bench axis for that reason. The field's own comment argued QEMU's default is the right one.Cache,cacheModes, the three validate cases about them, the flag, and their test rows gospin does not reference the field (grep over spin main), so its next module bump compiles as is. Local mutate, empty SPIN_MACHINE_OUTPUT: 23 refused, 0 survived.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.