boot: cmp.Or where orElse was, and the baseline written where it starts - #95
Merged
Merged
Conversation
orElse was cmp.Or with its arguments the other way round, and the package already used cmp.Or. cmdlineVariants held one row since the hash-table row was measured and dropped. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
aledbf
force-pushed
the
boot/small-leftovers
branch
from
October 2, 2026 00:09
015404a to
e7ace46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orElse(dflt, override)wascmp.Or(override, dflt), which the package already uses (bench_test.go's SPIN_MACHINE_OUTPUT); its six calls use cmp.OrcmdlineVariantswas a one-element slice since its second row was measured and dropped; SPIN_APPEND_B covers a second command line. The baseline is written where the list starts, and the comment names command line B beside kernels B and C🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.