release: the verdict sees machine/, not only the files it hashes - #98
Merged
Merged
Conversation
fingerprint-diff compared qemu, kernel, bios and pvh, so a change to what machine/ hashes or how - #97 folded the fingerprint into one hash - moved every fingerprint while the verdict said checkpoints still resume. hack/release records Fingerprint itself, of the shipped tree with a named CPU, as fingerprint_sha256, and the verdict compares it with the rest. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v20261002.01's notes say "Checkpoints taken against v20261001.02 still resume". They do not: #97 changed how the fingerprint is hashed, and fingerprint-diff only compared the files Fingerprint hashes. A change to machine/ - a device added, the shape, the hashing - moves every fingerprint and was invisible to the verdict.
fingerprint_sha256into machine.env:spin-machine fingerprintof the shipped tree with a named CPU (Skylake-Server-v4), so no runner's own CPU enters it. spin pins go.mod to the release's commit (hack/spin-machine refuses otherwise), so this is the machine/ spin computes with.Checked: the extraction yields the 64-hex fingerprint of _output; fingerprint-diff against v20261002.01 gives the partial verdict.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.