fix: Preserve embedded NUL characters in TEXT values - #634
Open
LiGuolongHAN wants to merge 1 commit into
Open
LiGuolongHAN wants to merge 1 commit into
LiGuolongHAN wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of SQLite TEXT values containing embedded NUL (\0) characters.
Previously, some JS ↔ SQLite string conversions treated TEXT as NUL-terminated, which could truncate values such as "A\0漢😄".
This change uses explicit UTF-8 byte lengths when passing strings into SQLite, and SQLite-reported byte lengths when reading them back.
It also adds regression tests for:
prepared statement parameters and query results;
JavaScript SQL function arguments and return values.
The new regression tests fail on the current master and pass with this fix. CI is green.