Repository navigation
Conversation
Add an optional `control: false` to the driver config. The driver then stays read-only: the metrics still arrive, DRIVER.controls is empty and driver_command never publishes Z1_Heat_Request_Temp, so Home Assistant or the pump's own controller keeps the heat curve offset. Without the option nothing changes. `control` also accepts 0, "false", "no" and "off" for string configs. Registers and fields are unchanged. Covered by a harness test (default on, true, the false spellings, and no publish from command, default mode or cleanup); not yet checked on hardware. Reported downstream in murre87/energywizard#491. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Signed-off-by: Emil Axfors <[email protected]>
murre87
added a commit
to murre87/energywizard
that referenced
this pull request
Nov 20, 2026
NOTICE: heishamon control: false skickad till källan (srcfl/device-drivers#238)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A site that runs
heishamononly for the metrics (heat pump power, temperatures) but lets Home Assistant or the pump's own controller own the Zone 1 heat curve offset has no way to say so. The driver always offersset_heat_curve_offset, and the host shows it. Downstream, EnergyWizard (murre87/energywizard#491) runs this driver with the offset left to Home Assistant.0.8.1 already stops default mode and cleanup from overwriting an offset FTW never wrote (#233, #235). It does not stop an operator or host from commanding one.
Change
One driver,
heishamon0.8.1 -> 0.8.2:control. Withcontrol: falsethe driver is read-only: the metrics still arrive,DRIVER.controlsis empty, anddriver_commandreturnsfalsewithout publishingZ1_Heat_Request_Temp. Default mode and cleanup therefore never publish either, becauseftw_wrote_offsetis only set by a command.controlalso accepts0,"false","no"and"off"for configs that arrive as strings; anything else set keeps control on.make bump-driver ID=heishamon LEVEL=patch; manifest, index and support status regenerated;CHANGELOG.mdentry under[Unreleased].Tests
drivers/tests/lua_harness/test_heishamon_control_option.lua(run bytest_heishamon_control_option.py): default on,true, each of thefalsespellings, each of thetruespellings; with control off noZ1_Heat_Request_Temppublish comes fromdriver_command,driver_default_modeordriver_cleanup. The test fails againstmain(assertion onDRIVER.controls, line 41) and passes with the change.make check: 5092 passed, 951 skipped, exit 0.check-versionsagainst the publisheddrivers-betamanifest reports onlyheishamonas changed (published version is 0.8.1).Not done
control: falsehas only the harness test above; it has not run against a Heishamon and a Panasonic Aquarea.verification_notessays so. This stays a draft until someone with the hardware has run it.Prepared with an AI assistant (Claude Code). Please review.