Skip to content

feat(heishamon): optional control: false read-only mode (0.8.2) - #238

Draft
murre87 wants to merge 1 commit into
srcfl:mainfrom
murre87:heishamon-control-option
Draft

murre87 wants to merge 1 commit into
srcfl:mainfrom
murre87:heishamon-control-option

Conversation

@murre87

@murre87 murre87 commented Nov 20, 2026

Copy link
Copy Markdown

Problem

A site that runs heishamon only for the metrics (heat pump power, temperatures) but lets Home Assistant or the pump's own controller own the Zone 1 heat curve offset has no way to say so. The driver always offers set_heat_curve_offset, and the host shows it. Downstream, EnergyWizard (murre87/energywizard#491) runs this driver with the offset left to Home Assistant.

0.8.1 already stops default mode and cleanup from overwriting an offset FTW never wrote (#233, #235). It does not stop an operator or host from commanding one.

Change

One driver, heishamon 0.8.1 -> 0.8.2:

  • New optional config control. With control: false the driver is read-only: the metrics still arrive, DRIVER.controls is empty, and driver_command returns false without publishing Z1_Heat_Request_Temp. Default mode and cleanup therefore never publish either, because ftw_wrote_offset is only set by a command.
  • Without the option nothing changes. control also accepts 0, "false", "no" and "off" for configs that arrive as strings; anything else set keeps control on.
  • Registers and fields are unchanged. Version raised with make bump-driver ID=heishamon LEVEL=patch; manifest, index and support status regenerated; CHANGELOG.md entry under [Unreleased].

Tests

  • New drivers/tests/lua_harness/test_heishamon_control_option.lua (run by test_heishamon_control_option.py): default on, true, each of the false spellings, each of the true spellings; with control off no Z1_Heat_Request_Temp publish comes from driver_command, driver_default_mode or driver_cleanup. The test fails against main (assertion on DRIVER.controls, line 41) and passes with the change.
  • make check: 5092 passed, 951 skipped, exit 0.
  • check-versions against the published drivers-beta manifest reports only heishamon as changed (published version is 0.8.1).

Not done

  • No hardware result. control: false has only the harness test above; it has not run against a Heishamon and a Panasonic Aquarea. verification_notes says so. This stays a draft until someone with the hardware has run it.
  • The existing 0.8.0 and 0.8.1 hardware notes are unchanged.

Prepared with an AI assistant (Claude Code). Please review.

Add an optional `control: false` to the driver config. The driver then stays
read-only: the metrics still arrive, DRIVER.controls is empty and
driver_command never publishes Z1_Heat_Request_Temp, so Home Assistant or the
pump's own controller keeps the heat curve offset. Without the option nothing
changes. `control` also accepts 0, "false", "no" and "off" for string configs.

Registers and fields are unchanged. Covered by a harness test (default on,
true, the false spellings, and no publish from command, default mode or
cleanup); not yet checked on hardware.

Reported downstream in murre87/energywizard#491.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Signed-off-by: Emil Axfors <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant