Skip to content

A second short dead-link outage within 5 min of an early trial holds the inverter's forced mode up to 5 min #1934

Open

Description

@frahlg

Follow-up from #1909 (owner decision, 28 Oct 2026: same as master, fix after stable).

When a battery comes back from an outage, #1909 gives it one early trial of its default mode. If a second short dead-link outage (under the 60 s watchdog) starts within 5 min of that trial, before the battery command was accepted, Core cannot tell it apart from a device that refuses commands on a flaky link. It then waits out the 5 min refusal window, and the inverter can hold its last forced command for up to 5 min.

Making this case return early today would bring back a default and a trial after every failed read for a device that truly refuses (TestDriverRefusingOnFlakyLinkGetsOneEarlyTrial). A second signal is needed, for example the length of the failed-read run.

Test: the reviewer's TestReviewSecondDeadLinkOutageAfterReturn with a 1 min idle gap: the default goes out within 10 s of the second return, while the flaky-link test still gives 1 trial and 2 defaults in 5 min.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions