Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bundle-sungrow-outage.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ftw": patch
---

Bundle sungrow 1.6.1. After the inverter drops off the network and comes back, the driver writes the release instead of reporting it held. A forced charge or discharge left over from before the outage now usually ends within about a minute of the return. Before, it ran for three to eight minutes, or did not end. The driver also keeps reading the battery's direction and PV, instead of dropping them for the session.
2 changes: 1 addition & 1 deletion drivers/BUNDLED_SOURCE.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"from the signed channel. Run scripts/sync-bundled-drivers.sh to update."
],
"repository": "srcfl/device-drivers",
"commit": "57984984a9bf6939d5206c5a05138296d9c6d940",
"commit": "46b28a1cb968bb81cf30df9290cfca816d1d91b9",
"source_dir": "drivers/lua",
"drivers": [
"ambibox_v2x", "ctek", "ctek_hybrid", "ctek_v2", "deye", "easee_cloud",
Expand Down
91 changes: 91 additions & 0 deletions go/internal/drivers/sungrow_driver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package drivers
import (
"context"
"encoding/json"
"errors"
"fmt"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -355,3 +357,92 @@ func TestSungrowProbesTheHybridBlockWhenTheDeviceTypeNeverAnswers(t *testing.T)
"running state; the probing fallback is not working")
}
}

// offlineModbus fails every read and write the way FTW's Modbus client does
// while the inverter is unreachable: the dial error the site rig logged for
// reads, and the reconnect backoff for writes.
type offlineModbus struct {
*recordingModbus
offline bool
}

func (m *offlineModbus) Read(addr uint16, count uint16, kind int32) ([]uint16, error) {
if m.offline {
return nil, errors.New("dial tcp 127.0.0.1:502: connect: connection refused")
}
return m.recordingModbus.Read(addr, count, kind)
}

func (m *offlineModbus) WriteSingle(addr uint16, value uint16) error {
if m.offline {
return fmt.Errorf("%w for 1.243s", ErrModbusBackoff)
}
return m.recordingModbus.WriteSingle(addr, value)
}

func (m *offlineModbus) WriteMulti(addr uint16, values []uint16) error {
if m.offline {
return fmt.Errorf("%w for 1.243s", ErrModbusBackoff)
}
return m.recordingModbus.WriteMulti(addr, values)
}

// An inverter that drops off the network for a while is not an inverter
// without registers. The random site rig (27 October 2026) took the Sungrow
// offline while it held a forced discharge. sungrow 1.6.0 counted the failed
// writes as the device refusing the EMS block, then reported the release as
// held without writing it, so the inverter kept discharging for up to five
// minutes after it came back. It also counted the failed reads as missing
// registers and dropped 13000, which signs the battery.
func TestSungrowOutageKeepsTheReleaseAndTheBatterySign(t *testing.T) {
tel := telemetry.NewStore()
modbus := &offlineModbus{recordingModbus: newRecordingModbus()}
modbus.regs[4999] = 0x0E0E // SH10RT
modbus.regs[13000] = 0x0004
modbus.regs[13021] = 900 // battery power, unsigned; 13000 says discharging
modbus.regs[13022] = 550
env := NewHostEnv("sungrow", tel).WithModbus(modbus)
env.BatteryCapacityWh = 9600
d, err := NewLuaDriver("../../../drivers/sungrow.lua", env)
if err != nil {
t.Fatalf("load: %v", err)
}
defer d.Cleanup()
ctx := context.Background()

if _, err := d.Poll(ctx); err != nil {
t.Fatalf("poll: %v", err)
}
cmd, _ := json.Marshal(map[string]any{"action": "battery", "power_w": -3000})
if err := d.Command(ctx, cmd); err != nil {
t.Fatalf("forced discharge: %v", err)
}

modbus.offline = true
for i := 0; i < 6; i++ {
untilNextFullRead(env)
_, _ = d.Poll(ctx)
if err := d.DefaultMode(); err == nil {
t.Fatalf("default mode %d reported success while nothing reached the device", i)
}
}
modbus.offline = false

if err := d.DefaultMode(); err != nil {
t.Fatalf("default mode after the device returned: %v", err)
}
if got := modbus.regs[13049]; got != 0 {
t.Fatalf("EMS mode = %d after the device returned, want 0: the "+
"release was skipped and the forced discharge kept running", got)
}

untilNextFullRead(env)
if _, err := d.Poll(ctx); err != nil {
t.Fatalf("poll after the device returned: %v", err)
}
reading := tel.Get("sungrow", telemetry.DerBattery)
if reading == nil || reading.RawW != -900 {
t.Fatalf("battery reading = %+v, want -900 W: 13000, which signs it, "+
"was dropped during the outage", reading)
}
}
Loading