Skip to content

fix(drivers): bundle heishamon 0.8.1, an offset set elsewhere stays - #2036

Merged
frahlg merged 1 commit into
masterfrom
bundle-heishamon-081
Nov 17, 2026
Merged

frahlg merged 1 commit into
masterfrom
bundle-heishamon-081

Conversation

@frahlg

@frahlg frahlg commented Nov 17, 2026

Copy link
Copy Markdown
Member

Problem

heishamon 0.8.0 published safe_offset (default 0) to Z1_Heat_Request_Temp from both driver_default_mode() and driver_cleanup(). Core runs default mode at every start and on watchdog trips, so an offset the owner set from Home Assistant went back to 0 each time, even on a site where FTW never commanded the pump (srcfl/device-drivers#233, reported by @Romaost).

Change

  • The pin moves from 1e4b5de7 to 940a9136, which is fix(heishamon): reset the offset only after FTW wrote one (0.8.1) device-drivers#235 (heishamon 0.8.1). heishamon is the only bundled driver that changes.
  • 0.8.1 resets the offset only after FTW wrote one. A failed reset keeps trying on the next default mode.
  • New test TestHeishamonLeavesAnOffsetFTWNeverWrote runs the driver through Core's own Lua host, whose mqtt_publish returns nothing on success. The device-drivers mock returns true, so this checks the path the harness cannot.
  • Changeset: patch.

Known limit

After a Core crash the driver no longer knows FTW wrote, so that offset stays on the pump. Today only the operator's offset control on the heating card sends set_heat_curve_offset, so the value that stays is one the owner chose.

Tests

  • TestHeishamonLeavesAnOffsetFTWNeverWrote fails on 0.8.0 (two publishes of 0) and passes on 0.8.1. The existing TestHeishamonClampsOffsetAndDefaultModeResetsIt still passes: after a command, default mode still resets.
  • scripts/sync-bundled-drivers.sh --check passes.
  • make verify: vet, test and build clean.
  • device-drivers CI on 940a9136: validate, pages and ftw-drivers-release green.

Not yet checked on hardware. @Romaost has offered to test on WH-SXC09H3E8.

Draft #1792 also edits drivers/BUNDLED_SOURCE.json. The pin has moved several times since it was opened, so its rebase does not change with this one.

🤖 Generated with Claude Code

srcfl/device-drivers#235 makes default mode and cleanup reset
Z1_Heat_Request_Temp only after FTW wrote an offset. Core runs default
mode at every start and on watchdog trips, so an offset set from Home
Assistant went back to 0 each time (srcfl/device-drivers#233). The pin
moves 1e4b5de7 to 940a9136; heishamon is the only driver that changes.

The new test runs the driver through Core's own Lua host, whose
mqtt_publish returns nothing on success.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Fredrik Ahlgren <[email protected]>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T06:23:04.630367Z a618089 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg
frahlg merged commit 4b8d65e into master Nov 17, 2026
21 checks passed
@frahlg
frahlg deleted the bundle-heishamon-081 branch November 17, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant