Repository navigation
chore(optimizer): bundle Energyplan 0.7.0 at 7ea7d998 - #2038
Merged
Merged
Conversation
The worker keeps a battery that may not cover the car out of the car's import room (srcfl/energyplan#83 for the library, #84 for the fleet model that plans every request where a car can charge), the rule Core enforces since #2023. The binaries are byte-identical to the ones Energyplan's local CI tested on 55118a38, which has the same tree as 7ea7d998. A native test plans the field night with the bundled worker and needs Core to accept the plan. With the bundle it replaces (847936a) Core rejects the plan in slot 0. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Fredrik Ahlgren <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #2023, Core rejects a worker plan in which the battery covers the house
while a car it may not cover charges on the import room that frees. The
bundled worker (Energyplan 847936a) still planned that way on nights when the
fuse binds. A site with one battery and one car then gets Core DP's plan, and
since #2037 a site Core cannot plan itself gets the worker's plan with a
warning.
Change
library (srcfl/energyplan#83) and in its fleet model (srcfl/energyplan#84),
which plans every request where a car can charge. Only the two Linux
workers and
manifest.jsonchange; license, notices and schemas are thesame.
go/internal/mpc/native_car_room_test.goplans the field night of15 Nov 2026 (
fuseNightSlots) with the bundled worker and needs Core toaccept the plan, with no slot where discharge makes the car's room.
Evidence
passed with on 55118a38 (35 of 35 stages on the Mac mini, Linux arm64),
which has the same tree as 7ea7d998. sha256: linux-arm64
b56d705e…,linux-amd64
22bec2f4….make native-solver-testpasses,with the handshake.
TestNativeBatteryThatMayNotCoverTheCarMakesItNoRoompasses in arbitrage and passive arbitrage (
fleet_milp_rust, the car at71 % by slot 7). With master's bundle (847936a) the same test fails:
"optimizer plan rejected: slot 0 battery discharge makes the import room
for loadpoint car".
make verifypasses. The bundle has no macOS worker, sonative execution is skipped there.
Merging needs Fredrik's yes.
🤖 Generated with Claude Code