Repository navigation
Conversation
miravoss26
reviewed
Nov 19, 2026
miravoss26
left a comment
Contributor
There was a problem hiding this comment.
What it does: the EV power-flow bubble shows "not connected" when `ev_connected === false`, and "connected · no power data" when connected without a power reading, instead of "idle"/"no data". Also preserved through control-feedback marks.
Read: small and local to `web/`; the tests cover the unplugged case for null/0/1000 W, connected-idle unchanged, and the feedback-mark case. No security surface (no new deps, network calls or authz). Validated on a live Pi per the description.
- nit: in `flowReadingsFromStatus` the second pass over `markedPlanets` re-derives the same disconnected/no-power states already handled when the planet is built. Fine for now, but it's two places to keep in sync.
Safe to merge from my read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The power-flow bubble showed “idle” or “no data” when the car was unplugged. It now shows “not connected” from the charger’s connection state. A connected car without a power reading shows “connected · no power data”, including when control feedback reports stale power.
Validated on a live Pi running v0.165.1-beta.1. The bubble changed from “not connected” to “idle” after plugging in, then to “charging” during manual charging, with about 10.3 kW reported by the charger. The missing-power case is covered with synthetic status and control-feedback data.
All 946 web tests passed.
make verifypassed after syncing the bundled driver snapshot to the release's pinned commit. Native worker execution tests were skipped because this development host has no bundled worker.The Pi has the visually checked patch. The final missing-power regression correction was verified locally and is included here.