Repository navigation
Let a new sign-up put an address back after it left that list - #6
Open
wachtelhund wants to merge 1 commit into
Open
wachtelhund wants to merge 1 commit into
wachtelhund wants to merge 1 commit into
Conversation
POST /subscribe already answered ok when a list-scoped unsubscribe suppression dropped the sign-up, so status stayed false. Any form now lifts that list's unsubscribe and signs the address up again. Bounce, complaint, and Mailchimp-cleaned are unchanged.
miravoss26
reviewed
Nov 19, 2026
miravoss26
left a comment
There was a problem hiding this comment.
Lets a new sign-up for a list lift that list's unsubscribe suppression and puts the address back. Docs, code and tests are updated together, CI test is green.
- Needs a human decision (consent): with open forms and no double opt-in, anyone can type another person's address and undo that person's unsubscribe. The PR description already says this stays until double opt-in. For a mailing list that is a consent and marketing-law question (GDPR / marknadsföringslagen), not just a product one. A cheap mitigation: only lift when the sign-up comes from a keyed server form, not an open browser form.
- Scope looks right: the
DELETEonly matchesscope = list AND reason = 'unsubscribe', so bounce, complaint, Mailchimp-cleaned and*suppressions stay. It runs first in the sameDB.batch, so thefreecheck sees it. - Tests cover the other-list case and all three hard-suppression reasons.
Code is fine from my read. Needs a human decision on the consent question before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST
/subscribealready answered{ok: true}when a list-scopedunsubscribesuppression dropped the sign-up, so status stayedsubscribed: false.A new sign-up for a list, from any form or client, now lifts that list's
unsubscribesuppression and puts the address back. Bounce, complaint, and Mailchimp-cleaned are never lifted. Known contacts and existing consent records are still left alone.This is the general form of the rule in #4, which #5 reverted because it special-cased
sourceful-app. Open web forms can still be used to sign someone else up again after they left. That is the same class of risk as the first sign-up, and stays until double opt-in.Do not merge or deploy from this author.