Conversation
xeniape
marked this pull request as ready for review
October 1, 2026 09:04
razvan
reviewed
Oct 1, 2026
Comment on lines
+67
to
+68
| # Required to maintain the CRD. The operator needs to do this, as it needs to enter e.g. it's | ||
| # generated certificate in the conversion webhook. |
Member
There was a problem hiding this comment.
I find this easier to read and understand
Suggested change
| # Required to maintain the CRD. The operator needs to do this, as it needs to enter e.g. it's | |
| # generated certificate in the conversion webhook. | |
| # The operator writes the generated webhook certificate into the CRD's | |
| # conversion webhook configuration. |
Comment on lines
+60
to
+61
| # Required for maintaining the CRDs within the operator (including the conversion webhook info). | ||
| # Also for the startup condition check before the controller can run. |
Member
There was a problem hiding this comment.
This reads better imo.
Suggested change
| # Required for maintaining the CRDs within the operator (including the conversion webhook info). | |
| # Also for the startup condition check before the controller can run. | |
| # Required to maintain the CRDs and to report their installation state | |
| # via the /ready endpoint (list/watch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#828. Adds the
/readyendpoint served on the Webhook Server, which informs about the CRD install state. Also adds an crd_established signal forAuthenticationClass,S3Bucket, andS3Connection, which were missing before. Also adds the required permissions for that signal.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker