feat: Add OpenShift Route support for Listeners - #435
Draft
marc-merino wants to merge 1 commit into
Draft
marc-merino wants to merge 1 commit into
marc-merino wants to merge 1 commit into
Conversation
Open
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #303.
Adds the
OpenShiftRouteListenerClass service type. For a Listener using such a class, the operator:ClusterIP, plus aroute.openshift.io/v1Route with the same name, labels and owner reference. The labels matter because they also decide which router shards will accept the Route.openshiftRoute.port, or picked automatically when the Listener has only one port.tls: Noneexposes plain HTTP on port 80.Admittedstatus condition) intoListener.status.ingressAddressesasHostnameaddresses. Hostnames that are not yet accepted, or were rejected, may be claimed by other Routes and are not published.The Route API is detected once at startup. On clusters without it, nothing changes: no Route watch and no Route API calls. A Listener whose class uses
OpenShiftRoutereports an error saying Routes aren't supported on the cluster.Routes are managed outside
ClusterResources, because that requires every managed resource type to exist on every cluster.Definition of Done Checklist
Author
openshift-routekuttl test (OpenShift dimension only); not yet run on an OpenShift clusterReviewer
Knit Bundle
View bundle
This PR is part of Knit bundle
openshift-route-listeners.See the other review objects in this bundle:
operator-rs: feat(stackable-operator): Add OpenShift Route Listener service type operator-rs#1291listener-operator: feat: Add OpenShift Route support for Listeners #435 (this PR)Blocked on operator-rs #1291
Bundle id:
openshift-route-listenersBundle title: Add OpenShift Route support to Listeners