Repository navigation
fix: report oversized simulated fees instead of TxMalformed - #100
Merged
Merged
Conversation
pselle
marked this pull request as ready for review
October 25, 2026 13:54
pselle
force-pushed
the
fix/fee-overflow-error
branch
from
October 25, 2026 14:01
092a286 to
43e832d
Compare
stellar-cli zeroes the fee when simulation exceeds the u32 fee field, so deploy submitted it and failed with an opaque TxMalformed. Co-Authored-By: Claude <[email protected]>
pselle
force-pushed
the
fix/fee-overflow-error
branch
from
October 25, 2026 14:02
43e832d to
de1ed43
Compare
chadoh
approved these changes
Oct 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to stellar-registry/contracts#73. On testnet this fails with an opaque
TxMalformed:The real problem is a ~20K XLM rent charge (fixed in the contracts PR), but
simulate_and_assemble_transactionsets the fee to 0 when it doesn't fit in the u32 fee field, anddeploy/deploy-unnamedsubmitted it anyway. They now stop before signing:I didn't add fee-bump support, since a fee that size is a bug rather than something to pay.