Repository navigation
Remove stellar-cli protocol version check - #1006
Merged
Merged
Conversation
fnando
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the check in
update-config-settingsthat fails when testnet's protocol is newer than the pinned stellar-cli's major version.Why
Testnet moved to protocol 29 while stellar-cli is still on 28, so the check fails every config settings update run and blocks updates. There are no changes to the config settings in p29, so right now this check is causing more pain than benefit.
Instead of erroring here when they are out of date, we'll address the potential for version lag by auto-updating instead: