Repository navigation
Skip PR image push when secrets are unavailable - #1008
Open
leighmcculloch wants to merge 2 commits into
Open
leighmcculloch wants to merge 2 commits into
leighmcculloch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip the image push and registry action test for pull requests whose builds can't access repository secrets, matching how fork PRs are handled.
Why
Dependabot PRs come from this repo but only receive Dependabot secrets, so the push falls back fails the build. We should just skip the build if there are no secrets on pull requests.
Note that we could also address this by not pushing when the pr author is dependabot, but secrets do become part of the build if a maintainer commits to the dependabot branch and so that change would prevent push from working then unnecessarily, hence this approach.
See the following PR to see how the failures occur: