Skip to content

Fix Property enumeration without local entries - #1087

Open
PHJ2000 wants to merge 1 commit into
stleary:masterfrom
PHJ2000:fix-properties-defaults-only
Open

PHJ2000 wants to merge 1 commit into
stleary:masterfrom
PHJ2000:fix-properties-defaults-only

Conversation

@PHJ2000

@PHJ2000 PHJ2000 commented Oct 5, 2026

Copy link
Copy Markdown

Remove the isEmpty() guard before enumerating Properties. Defaults are visible through propertyNames() and getProperty() even when there are no local entries.

Adds coverage for inherited defaults and local overrides. Maven clean verify passes with deployment signing disabled (-Dgpg.skip=true): 811 tests, 6 skipped.

Fixes #1086.

@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2026

Copy link
Copy Markdown

@stleary stleary changed the title Preserve inherited properties without local entries Fix Property enumeration without local entries Oct 8, 2026
@stleary

stleary commented Oct 8, 2026

Copy link
Copy Markdown
Owner

What problem does this code solve?
Fixes a bug in Property parsing where inherited values without a local entry are missed.

Risks
Low

Changes to the Existing Behavior
Yes, minor change to behavior. Property parsing is not widely used. Inherited properties are now parsed. This bug goes back to the original implementation, and appears to be a simple omission.

Changes to the API
No

Will this require a new release?
No

Should the documentation be updated?
No

Unit Tests
New unit tests were added

Refactoring
APPROVED

Starting 3-day comment window

Review status

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property.toJSONObject drops defaults when there are no local entries

2 participants