Skip to content

Fix off-by-one bounds checks of the Python wrapper matrix views #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KRGulaj wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −3
Open

Fix off-by-one bounds checks of the Python wrapper matrix views #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c57cb6b
Fix off-by-one bounds checks of the Python wrapper matrix views
KRGulaj Oct 6, 2026
fdffa4b
Add Kajetan R. Gulaj to AUTHORS.md
KRGulaj Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ JonathanSmith1936
Joseph Signorelli
Joshua A. Kelly
Josy P. Pullockara
Kajetan R. Gulaj
Kedar Naik
Kürşat Yurt
LaSerpe
Expand Down
7 changes: 4 additions & 3 deletions Common/include/containers/CPyWrapperMatrixView.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class CPyWrapperMatrixView {

/*--- Define the functions required by the interface macro. ---*/
inline const su2double& Access(unsigned long row, unsigned long col) const {
if (row > rows_ || col > cols_) SU2_MPI::Error(name_ + " out of bounds", "CPyWrapperMatrixView");
if (row >= rows_ || col >= cols_) SU2_MPI::Error(name_ + " out of bounds", "CPyWrapperMatrixView");
return data_[row * cols_ + col];
}
inline su2double& Access(unsigned long row, unsigned long col) {
Expand Down Expand Up @@ -133,7 +133,7 @@ class CPyWrapperMarkerMatrixView {

/*--- Define the functions required by the interface macro. ---*/
inline const su2double& Access(unsigned long row, unsigned long col) const {
if (row > rows_ || col > cols_) SU2_MPI::Error(name_ + " out of bounds", "CPyWrapperMarkerMatrixView");
if (row >= rows_ || col >= cols_) SU2_MPI::Error(name_ + " out of bounds", "CPyWrapperMarkerMatrixView");
return data_[vertices_[row]->GetNode() * cols_ + col];
}
inline su2double& Access(unsigned long row, unsigned long col) {
Expand Down Expand Up @@ -183,7 +183,8 @@ class CPyWrapper3DMatrixView {

/*--- Define the functions required by the interface macro. ---*/
inline const su2double& Access(unsigned long row, unsigned long col, unsigned long dim) const {
if (row > rows_ || col > cols_ || dim > dims_) SU2_MPI::Error(name_ + " out of bounds", "CPyWrapper3DMatrixView");
if (row >= rows_ || col >= cols_ || dim >= dims_)
SU2_MPI::Error(name_ + " out of bounds", "CPyWrapper3DMatrixView");
return data_[row * (cols_ * dims_) + col * dims_ + dim];
}
inline su2double& Access(unsigned long row, unsigned long col, unsigned long dim) {
Expand Down