Repository navigation
Conversation
Test casesReproducers, configurations, numeric logs and scripts: support. Develop =
The full configs, exact diagnostic logs and Python check are provided. The combined diagnostic runner also verifies the four streamwise restrictions handled in part D. Missing continuous-adjoint/radiation/structural periodic physics is not implemented by these guards. Combined release checks: serial and OpenMP2 pass 10 cases / 3175 assertions; partitioned MPI2 and MPI2×OpenMP2 pass on both ranks (2334 / 2238 assertions). These are combined-source checks, not standalone builds of every branch. Complete branch CI and full regression/reference checks remain pending. |
joshkellyjak
left a comment
There was a problem hiding this comment.
Nice catch, not sure a unit test for this functionality is strictly necessary
|
|
||
| if (Kind_SU2 == SU2_COMPONENT::SU2_CFD && nMarker_PerBound > 0) { | ||
| if (ContinuousAdjoint) | ||
| SU2_MPI::Error("Continuous adjoints do not implement MARKER_PERIODIC. Use MATH_PROBLEM= DISCRETE_ADJOINT.", |
There was a problem hiding this comment.
"MARKER_PERIODIC is not currently supported in the continuous adjoint solver. Use MATH_PROBLM= DISCRETE_ADJOINT"
same for two below
There was a problem hiding this comment.
Updated all three messages in 522998a to use "not currently supported". The discrete-adjoint suggestion remains only in the continuous-adjoint error.
|
@joshkellyjak Removed the additional unit tests and subprocess runner in 522998a, as suggested. The PR now only adds the configuration guards; the before/after configurations and diagnostic logs remain linked in the testcase comment. |
Proposed Changes
Unsupported periodic solver combinations are accepted without a periodic boundary implementation. This PR rejects them before solver construction.
Develop accepts periodic continuous-adjoint, radiation and structural configurations without implementations of those periodic boundaries. Configuration validation now stops these combinations with a specific error before solver construction.
Complete BOX configuration controls verify that develop accepts each input and the fixed source rejects it for the intended reason. A supported direct-flow control remains accepted. This adds support diagnostics; it does not implement those missing solvers.
Validation of the combined periodic source passes serial, partitioned MPI2, OpenMP2 and MPI2×OpenMP2 (10 cases / 3175 serial assertions). Individual branch CI and complete regression/reference checks are pending. Test configurations, meshes, logs and before/after values are in the testcase comment.
The PR only adds configuration guards. The additional unit tests and subprocess runner were removed following review; the before/after configurations and diagnostic logs remain available in the testcase comment.
Related Work
PR Checklist