Repository navigation
Conversation
|
Since it does not harm the current case, and it is expected to help in certain other cases, I think the better approach is to keep the correct term with max(v,0). |
|
Thanks, makes sense. I've switched to keeping the exact derivative w.r.t. (rho k, rho w), I didn't have a case with dominant radial velocity near the axis, so I set up two (incompressible SST, 4000 iterations, fixed CFL, before = develop, after = this PR): Pipe with a central rod (r0 = 5 mm, R = 50 mm) injecting radially at 5 m/s through a permeable section. Iterations to rms[P] = -11:
Round jet impinging on a plate (H/D = 2, Re = 23000). rms[P] / rms[k] after 4000 iterations:
So no harm, but also no measurable benefit in these two. I think the reason is that, since the axisymmetric volume is the planar cell area, the term relative to the convective Jacobian is about dy/y. Away from the axis (rod surface, first cell 1e-5 m at r = 5 mm) that's ~0.002. Next to the axis it tends to Volume * dv/dr, which is small compared to the beta* omega Volume dissipation entry. Happy to add one of these as a regression case if it's useful. |
Title: Fix overwritten axisymmetric Jacobian in the SST source
Proposed Changes
In
CSourcePieceWise_TurbSST::ComputeResidual,ResidualAxisymmetricConvectionDiffusionsubtracts itscontribution from the diagonal of
Jacobian_i, but the "Implicit part" right after it assignsJacobian_i[i][j] = ..., so that contribution was always discarded.This PR:
yinv * Volume * v(the previousdead code had
yinv * Volume * rho * v);max(v, 0). With both signs of v, the term isdestabilizing for flow towards the axis: on
air_nozzle_restartit stalls at rms[Rho] ~ -5.6, instead ofreaching -12 in 591 iterations.
Residuals are unchanged; only the convergence path differs, so the
air_nozzleregression values areupdated. Results on
air_nozzle_restart, a pipe with radial injection from a central rod, and an impinginground jet show no change in convergence (see the discussion below).
Related Work
#2948 edits the same implicit block of the SST source.
PR Checklist
pre-commit run --allto format old commits.