Artifact asset transfers - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds artifact downloads and asset uploads to the Python client, improves CLI result-output handling, and updates documentation.
Changes:
- Added secure transfer APIs and tests.
- Added explicit CLI output modes and stdout support.
- Added API workflow documentation and navigation.
| File | Summary |
|---|---|
tests/test_transfers.py |
Transfer contract and failure tests |
tests/test_cli.py |
CLI output-mode coverage |
src/subfork/resources.py |
Artifact and asset APIs |
src/subfork/client.py |
Transfer handling and resource registration |
src/subfork/cli.py |
Explicit result-output behavior |
README.md |
Updated usage references |
docs/usage.md |
API guide reference |
docs/mkpages.yml |
API navigation entry |
docs/cli.md |
Updated CLI documentation |
docs/api.md |
New API workflow guide |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces API support for artifact downloads and asset uploads, improves the CLI's handling of result output, and updates documentation to reflect these new workflows and options. The changes add
ArtifactsandAssetsresources to the Python client, implement secure file streaming and upload logic, and clarify CLI output behavior. Documentation is expanded with a new API/file workflow guide and improved references.API and Client Enhancements:
ArtifactsandAssetsresources to the Python client, with methods for downloading artifacts to local files (with safe handling, size limits, and redirect support) and uploading assets to graphs. [1] [2] [3]CLI Improvements:
executecommand to only emit result JSON when explicitly requested with-o/--outor--raw, and clarified the meaning of output options (including support for-o -to print to stdout). [1] [2] [3] [4]Documentation Updates:
docs/api.mdguide covering Python API usage for executing graphs, downloading artifacts, and uploading assets, with practical code examples.Testing:
These changes provide a more robust and user-friendly workflow for managing files and results in Subfork, both from the command line and programmatically.