Repository navigation
fix(export): use the renderer's split gap when fitting a target width #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
O1sumitkumar
wants to merge
2
commits into
suradet-ps:main
Choose a base branch
from
O1sumitkumar:fix/split-gap-target-width-30
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: suradet-ps/codeframe
Length of output: 5752
Script executed:
Repository: suradet-ps/codeframe
Length of output: 8606
Script executed:
Repository: suradet-ps/codeframe
Length of output: 3037
Apply the split scale to the SVG width attribute, not only to the PNG path.
The split SVG download ignores the computed scale.
render_split_svgwrites its logicaltotal_winto the rootwidthattribute, and the export code downloads that string unchanged. A split SVG export with a target width therefore keeps its logical width. The fix must make the emittedwidthandheightreflectoptions.scale, or otherwise apply the target to the SVG output, and the test must check the emitted SVG.Test note
split_scale_makes_export_match_target_widthcheckslogical_width * scaleagainst the target. It does not parse the SVG that is downloaded, so it passes while the file keeps its logical width. Assert on the emitted SVGwidthattribute.