Repository navigation
Leave the empty suggestion row blank - #1219
Merged
Merged
Conversation
The keyboard wrote a note across its suggestion row whenever the row was empty: Prediction loading, No suggestions, Type for suggestions and so on. Nothing is written across the keyboard any more; the row keeps its reserved slots and stays blank until suggestions arrive, so the panel never changes size. The Status tile role and the row label go with it, along with the held and tracking flags that only fed the note. If prediction fails, the Retry predictions key still appears. Closes #1218 Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Fable 5.1 <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1218
What changes
Statustile role, the panelrow_label, the keyboard's note builder, and the held and tracking flags that only fed the note.Validation
npm run prediction-model,npm run lint,npm test(310 vitest + 19 node),npm run build: pass.cargo fmt --check,cargo clippy --all-targets -D warnings,cargo test(839 passed): pass.sitebuilds.export_panel_size_fixtureson Windows: keyboard shows menu bar, a blank suggestion row, then the keys.🤖 Generated with Claude Code