Repository navigation
Conversation
There was a problem hiding this comment.
ℹ️ No critical issues — one tooling nit inline.
Reviewed changes
- Surfaced pre-auth SSH banners in Browser SSH.
cmd/hp_ssh/wasm_js.gonow installs anssh.ClientConfig.BannerCallback(viapatches/tsconnect-auth-banner.patch) that writes the banner to the terminal and invokes a newonAuthBannercallback. - Rendered the reauthentication link in the connection overlay.
page.tsxextracts the URL withgetAuthenticationURL(app/routes/ssh/auth-banner.ts) and shows the banner text plus an "Authenticate to continue" link untilonConnectedfires. - Threaded the callback end to end.
wasm_js.d.ts,ghostty.client.tsx, andghostty.client.tsx's transport passonAuthBannerinto the WASM termConfig. - Stabilised the Ghostty effect deps.
onConnectedandonAuthBannerare nowuseCallback-memoised, so the terminal is no longer torn down and recreated on parent re-renders. - Added a unit test, changelog entry, and sync-tooling update.
tests/unit/routes/ssh/auth-banner.test.tscovers extraction and rejection;CHANGELOG.mdgains a #591 fix line;scripts/sync-tsconnect.shapplies the new patch.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Loic-SM
force-pushed
the
fix/browser-ssh-reauthentication
branch
from
October 2, 2026 07:32
0195da3 to
2d11576
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The delta since the prior pullfrog review is a single tooling change:
- Consolidated the
termConfigpatch hunks.patches/tsconnect-types.patchnow folds the separatetermTypeandonAuthBanneradditions into one@@ -22,9 +33,12 @@hunk, replacing the mis-numbered third hunk the earlier review flagged.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Loic-SM
force-pushed
the
fix/browser-ssh-reauthentication
branch
from
October 2, 2026 07:38
2d11576 to
8f7e349
Compare
Author
|
Hey @tale , ready to review :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reference: #591 — Browser SSH fails with Tailscale SSH
action: "check"Tailscale SSH sends its re-authentication URL as a pre-auth SSH banner when an ACL rule uses
action: "check". Browser SSH previously ignored that banner, so the user could not complete re-authentication before the SSH handshake timed out.Summary
Verification
pnpm exec vitest run --project unit tests/unit/routes/ssh/auth-banner.test.tspnpm exec oxlint app/routes/ssh/auth-banner.ts tests/unit/routes/ssh/auth-banner.test.ts