Skip to content

fix: restore authentication restrictions link in settings - #646

Open
KutiFF wants to merge 1 commit into
tale:mainfrom
KutiFF:fix/settings-oidc-restrictions
Open

KutiFF wants to merge 1 commit into
tale:mainfrom
KutiFF:fix/settings-oidc-restrictions

Conversation

@KutiFF

@KutiFF KutiFF commented Oct 7, 2026

Copy link
Copy Markdown

Fixes #645.

The Authentication Restrictions link could disappear after restarting Headplane. This change checks Headscale's OIDC configuration instead of Headplane's discovery status, so the link stays visible.

Includes regression tests and a changelog entry.

@KutiFF
KutiFF requested a review from tale as a code owner October 7, 2026 15:20

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Restrictions link decoupled from Headplane discovery — app/routes/settings/overview.tsx now derives hasOidcConfig from headscaleConfig.hasOIDCConfig() instead of oidcContext, so the link no longer depends on Headplane's OIDC discovery reaching ready after a restart.
  • Consistent with the target page — the same hasOIDCConfig()/getOIDCConfig() path gates the restrictions route's loader (which throws 501 when OIDC is unconfigured), so the link cannot surface a page that fails to load.
  • Regression tests — tests/unit/settings/overview.test.ts covers the link for Headplane OIDC states pending/disabled/ready, plus hidden when Headscale has no OIDC config and when the config is not writable. The oidcContext mock acts as a tripwire: reverting to the old condition would fail the pending/disabled cases. Ran pnpm vitest run --project unit tests/unit/settings/overview.test.ts — 5 passed.
  • Changelog — Fixes entry under # Next closes #645.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@KutiFF KutiFF changed the title fix: restore Authentication Restrictions link in Settings fix: restore authentication restrictions link in settings Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC Restrictions link is missing from Settings, but direct route still works

1 participant