Repository navigation
Inspect ASAR for empty/missing JS modules in release verifier (#4) - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4 (code portion).
PR #5 already wired ASAR graph inspection into the verifier, afterPack, and release staging. This closes the two remaining extraction gaps, proven with a fixture ASAR that previously passed clean:
import"./chunk.js") were not extracted at all, so an empty or missing target escaped the check.Both fixes live in the shared inspector module, so the verifier, afterPack hook, and staging all gain them. 7 new tests (graph-level plus fixture-ASAR).
Verification: targeted integration specs 47 passed (inspector spec 24 -> 31); full integration sweep 67 passed; biome clean; typecheck exit 0 for covering workspaces. Still open from #4 (needs macOS CI): the packaged-app launch smoke test.