Skip to content

Inspect ASAR for empty/missing JS modules in release verifier (#4) - #15

Merged
tanRdev merged 1 commit into
mainfrom
fix/issue-4-release-asar
Nov 10, 2026
Merged

tanRdev merged 1 commit into
mainfrom
fix/issue-4-release-asar

Conversation

@tanRdev

@tanRdev tanRdev commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Closes #4 (code portion).

PR #5 already wired ASAR graph inspection into the verifier, afterPack, and release staging. This closes the two remaining extraction gaps, proven with a fixture ASAR that previously passed clean:

  • Minified side-effect imports (import"./chunk.js") were not extracted at all, so an empty or missing target escaped the check.
  • Combined default+named and default+namespace imports matched neither pattern, so missing/empty targets and missing named exports escaped.

Both fixes live in the shared inspector module, so the verifier, afterPack hook, and staging all gain them. 7 new tests (graph-level plus fixture-ASAR).

Verification: targeted integration specs 47 passed (inspector spec 24 -> 31); full integration sweep 67 passed; biome clean; typecheck exit 0 for covering workspaces. Still open from #4 (needs macOS CI): the packaged-app launch smoke test.

@tanRdev
tanRdev merged commit 292e0b9 into main Nov 10, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.9.3 macOS release cannot launch: zero-byte shared chunk in app.asar

1 participant