Repository navigation
Virtualize conversation history and preserve scroll position (#11) - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
createChatTurnsBuilder()preserves unchanged turn identities across renders instead of rebuilding every turn each render.virtual-turn-window.ts) with measured/estimated layout, bounded mounted selection (1200px overscan), exact spacer accounting, and anchor capture/resolve with a per-thread anchor store. Completed turns are windowed; the active/streaming turn is always mounted; a search-targeted turn is force-mounted so search reveal still lands on unmounted results.Verification: 78 tests across all specs touching these modules pass; desktop typecheck exit 0; biome, file-size, and import-boundary checks pass. Honest limitation: real-layout behavior is proven at the pure-math level (jsdom has no layout); a Playwright pass in the real Electron window is the follow-up for end-to-end scroll proof.