Skip to content

Code review reporting, diff-line questions, staged worktree setup (#12) - #19

Merged
tanRdev merged 4 commits into
mainfrom
feat/issue-12-review-worktree
Nov 10, 2026
Merged

tanRdev merged 4 commits into
mainfrom
feat/issue-12-review-worktree

Conversation

@tanRdev

@tanRdev tanRdev commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Closes #12.

  • Failed writes don't count: change reporting now counts only mutations with status === "complete", deduped; a failed write no longer counts and no longer erases an earlier success (new chat/file-changes.ts).
  • Diff-line questions: selections carry both oldLineNumber and newLineNumber plus side per selected line; clickable/keyboard selection wired GitPanel -> WorkspaceShell -> the existing agent-prompt path.
  • Whole-file staging: already present on main; verified against its 12 existing tests.
  • Worktree setup stages: staged runner (validate -> prepare-directory -> resolve-branch -> create-worktree -> ready) with onStage reporting; a failed setup keeps the checkout, and retry reuses an existing matching registered worktree instead of creating a duplicate (covered by a real-git integration spec); a path registered to a different branch fails untouched.
  • Edit and send again: relabeled from "Resubmit" with copy matching actual behavior (edited text sends as a new message; the original stays).

Verification: all new/touched specs pass (file-changes 9, diff-selection 8, diff-viewer 14, worktree unit 6 + real-git 3, git-panel 12, shell 33, app 13); full src/main 137 passed with only pre-existing failures identical on main; desktop tsc exit 0; biome clean; contracts 79/79. Remaining follow-on (deliberately not half-wired): surfacing stage progress inside the create-worktree dialog requires a new IPC channel.

@tanRdev
tanRdev merged commit dcedfd4 into main Nov 10, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P2: Connect code review and staged worktree setup

1 participant