Repository navigation
When saving template arguments to self.cookies transform MAGIC_*BRACK… - #438
Merged
Merged
Conversation
…ET_CHAR MAGIC_*BRACKET_CHAR are two magical characters used in a kludge for pairs of square brackets (`[]`) that are annoying to parse, but this was one point where I hadn't realize we need to transform them back; template arguments would have leaked magical characters, and because they could contain other, even nested magical characters, this was difficult to notice, and square brackets are rare in text in wikitext anyhow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ET_CHAR
Fixes tatuylonen/wiktextract#1725
MAGIC_*BRACKET_CHAR are two magical characters used in a kludge for pairs of square brackets (
[]) that are annoying to parse, but this was one point where Ihadn't realize we need to transform them back; template arguments would have leaked magical characters, and because they could contain other, even nested magical characters, this was difficult to notice, and square brackets are rare in text in wikitext anyhow.