Repository navigation
fix: log which import failed when resolving another group's output - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧑💻What is the change being made?
When a manifest
importsentry cannot be read from another resource group, terranova now logs a failure that names the import, its source group and the importing group, followed by a cause and resolution. This adds anImportOutputErrorand logs it inextract_output_varbefore exiting with the same exit code as before. Self-imports still raiseSelfImportNotReadyError.❓ Why is the change being made?
A failing import used to exit silently with only terraform's raw
outputstderr, so users could not tell whether the import or the resource group's own plan/apply had failed.✅ How has this been tested?
Added
test_error_logs_failing_import, which checks that stderr names the import, its source and the importing group, and includes a cause. Thetests/itsuite passes locally (368 tests), along withruffandbasedpyright.🔗 Related Issues
Closes #97