Skip to content

Fix pending Nexus task cleanup - #1962

Merged
tconley1428 merged 1 commit into
mainfrom
amazzeo/nexus-task-destroyed
Oct 14, 2026
Merged

tconley1428 merged 1 commit into
mainfrom
amazzeo/nexus-task-destroyed

Conversation

@VegetarianOrc

Copy link
Copy Markdown
Contributor

What was changed

  • Register Nexus operation tasks with the workflow instance to suppress pending-task destruction warnings and ensure normal cleanup during eviction.

Why?

  • Worker shutdown while a workflow waits for a Nexus operation can produce Task was destroyed but it is pending! warnings.
  • Nexus tasks should follow the same registration and eviction cleanup path as activity and child workflow tasks.

Checklist

  1. Closes [Bug] Nexus operation handle task logs "Task was destroyed but it is pending!" on worker shutdown/eviction #1960

  2. How was this tested:

  • Added integration tests to confirm eviction scenarios occur as expected.
  1. Any docs updates needed?

N/A

@VegetarianOrc
VegetarianOrc requested a review from a team as a code owner October 13, 2026 23:50
@PM-JoakimGustavsson

Copy link
Copy Markdown

@VegetarianOrc Thank you so much for looking into this so quickly!

@tconley1428
tconley1428 merged commit a8cb19f into main Oct 14, 2026
33 of 34 checks passed
@tconley1428
tconley1428 deleted the amazzeo/nexus-task-destroyed branch October 14, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Nexus operation handle task logs "Task was destroyed but it is pending!" on worker shutdown/eviction

3 participants