Skip to content

linux: keep PTP running when interface sends fail - #1

Open
DrEVILish wants to merge 2 commits into
teodly:inferno-devfrom
DrEVILish:link-down-no-panic
Open

DrEVILish wants to merge 2 commits into
teodly:inferno-devfrom
DrEVILish:link-down-no-panic

Conversation

@DrEVILish

Copy link
Copy Markdown

Summary

Taking the interface down aborts the daemon on failed PTP sends. Treat a failed send as a lost packet and keep successful-send timestamp handling unchanged for IP and Ethernet.

-send failure -> panic
+send failure -> warn, continue processing actions

Evidence

  • Before: base 244f20a panics on general-send NetworkUnreachable during link-down.
  • After: isolated namespace test observes event/general send failures without panic; PTP packets resume after recovery for IPv4 and Ethernet.
  • python3 statime-linux/tests/link_down.py target/debug/statime passed. Uses a dummy interface, virtual monotonic clock and disabled clock export.
  • Workspace retry passed 78 unit tests and 16 doctests (two ignored). Initial existing software-timestamp test flaked; isolated and workspace retries passed. IPv6 was not separately exercised.

Merge Danger

Door: two-way

Blast Radius: networking

Reviewed with sol-loop: 1 round with gpt-6.1-sol on medium. Sol verdict: approved.

Created with gpt-6.1-sol in T3 Code. Regression script by gpt-6.1-sol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant