[neogiacomo]

What and why

Part 1/6 of #2197's BFV configuration stack, based on main. Review and merge predecessors first; review follow-ups are kept in #2353.

• Put scheme/version domains and exact parameter/configuration-ID derivation in e3-fhe-params.
• Make runtime admission and the historical indexer use that owner without decoding/re-encoding registry bytes for identity checks.
• Keep independent current/historical ABI/hash vectors, current-only request admission, and explicit historical indexer handling.
• Enable CI for dependent PRs targeting stack branches, without changing publication protections.

Current baseline and verification

Restacked on main ea058724ef630d864614ddcd1887033e2793fdc4, including #2349's coordinated Noir rc.3 / BB 6.0.0 upgrade. Protocol 9, generation 2, and BFV domain v5 are inherited; this layer adds no counter change. Published #2341 was already on this baseline and its tip is preserved.

Whole-stack current evidence is recorded in #2353, not in architecture documentation. It includes frozen identity/metadata/source checks, 300 independently rederived latest VKs and 12 Solidity verifiers, a fresh default-source build matching all 102 published key/hash/anchor files, 853 prepared contract tests, seven SDK WASM proof tests, and nine native leaf plus three fold/node proof tests against latest. Do not treat historical beta.26/BB5.2 results as current qualification.

Matching CI run 40299772538 passed for 5f0d129f8721. All seven matching stack CI runs are green, and #2353 is ready for review. Rewritten branches were published using recorded exact leases and ordinary hooks. These cumulative whole-stack results do not claim every follow-up fix already exists in this individual layer.

Compatibility and limits

Relative to current main, the read-only review found no further parameter/configuration-ID/domain, committee order, T+1/H, proof multiplicity, public-input layout, production ABI/storage/events, durable-schema, or wire-format change. Frozen vectors remain independent; current slot-0/slot-2 admission and explicit historical handling remain intact. Human protocol review is still required.

Review references: artifact boundaries, proof statements, threshold decryption, protocol history, and upgrades.

#2346 explicitly reconciles 18/42 catalogue expectations with main's already-breaking toolchain cutover. Main's matching rc.3/BB6 verifier/artifact combination remains supported; protocol-8/beta.26/BB5.2 compatibility is not promised. Source stamps are preserved, not relabelled. Old-data replay and mixed-peer formats are unchanged, but no new live mixed-fleet/replay qualification is claimed. Rollback stays within the matching protocol-9 baseline and never decreases counters.

Fresh all-pair source-bound release qualification, historical #2195 replay/recurring-file measurement, exhaustive live-fleet/release qualification, and matching immutable public pins/public-release E2E for CRISP draft #6 remain separate. CRISP stays release-blocked. No migration, governance action, merge, tag, release, deployment, or artifact publication is performed or authorized.

Stack: #2341 → #2342 → #2343 → #2344 → #2345 → #2346 → #2353.

Summary by CodeRabbit

• New Features

  • Added shared BFV protocol identity calculations and compatibility checks for current and historical configurations.
  • CI now runs for pull requests targeting any branch.

• Documentation

  • Clarified BFV protocol identity, compatibility, and parameter-handling guidance.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
interfold-dashboard	Ready	Preview	Oct 26, 2026 9:29am UTC
interfold-docs	Ready	Preview	Oct 26, 2026 9:29am UTC

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1

• Cargo.lock is excluded by !**/*.lock

Run configuration

• Source mode: Auto
• Repository: theinterfold/interfold
• Branch: main
• File: .coderabbit.yaml
• Commit: ea05872
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 36c74e05-2975-4513-abe3-1b763cd0e552

Commits

Reviewing files that changed from the base of the PR and between 62ec6dc and 5f0d129.

Files ignored due to path filters: 1

• Cargo.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: theinterfold/interfold
• Branch: main
• File: .coderabbit.yaml
• Commit: 3561619
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: aead269c-406e-4851-8e7d-b29435704c59

📥 Commits

Reviewing files that changed from the base of the PR and between 8a573cf and 62ec6dc.

📒 Files selected for processing: 2

• AGENTS.md
• crates/fhe-params/README.md

🚧 Files skipped from review as they are similar to previous changes: 1

• crates/fhe-params/README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request centralizes BFV parameter and configuration identity helpers in e3-fhe-params, updates the builder, EVM decoder, and indexer to use them, and adds frozen compatibility vectors and tests. It also expands CI pull-request triggers to all target branches.

Changes: BFV protocol identity

Layer / File(s)	Summary
Shared identity API and compatibility vectors crates/fhe-params/src/*, crates/fhe-params/tests/*, crates/fhe-params/Cargo.toml, crates/fhe-params/README.md, AGENTS.md	e3-fhe-params exposes BFV scheme, parameter-hash, and configuration-ID helpers. Frozen current and historical vectors drive compatibility tests, including checks for exact encoded parameter bytes. Documentation describes the vectors and identity constraints.
Identity use in runtime and build code crates/zk/build/src/*, crates/zk/build/templates/*, crates/evm/src/interfold/events.rs, crates/indexer/src/indexer.rs, docs/architecture/*	The builder, EVM event decoder, and indexer use shared identity helpers for current or historical configuration IDs. Tests use fixture values or shared helpers. Architecture docs describe protocol identity ownership.

CI pull request branch coverage

Layer / File(s)	Summary
Pull request trigger scope .github/workflows/ci.yml	The pull_request trigger no longer limits CI runs to pull requests targeting main or dev.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Possibly related issues

• theinterfold/interfold#2319: The changes implement the issue’s described BFV parameter and circuit/configuration identity consolidation.
• theinterfold/CRISP#2: The changes centralize BFV identity formulas and add compatibility checks for downstream consumers.

Suggested reviewers: ctrlc03, hmzakhalid

Merge Risk: Minimal · up to 62ec6

The BFV identity refactor preserves current and historical behavior while broadening pull-request CI coverage. No material merge-blocking risk is established.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 8 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: centralizing BFV protocol identity derivation.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 8 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}