Skip to content

Fixup: ASoC: SOF: Intel: wait and verifies the presence of SoundWire peripherals - #6016

Open
bardliao wants to merge 2 commits into
thesofproject:topic/sof-devfrom
bardliao:ghost-Peripherals
Open

bardliao wants to merge 2 commits into
thesofproject:topic/sof-devfrom
bardliao:ghost-Peripherals

Conversation

@bardliao

@bardliao bardliao commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Wait for each SoundWire peripheral's enumeration to complete instead of
assuming that all peripherals enumerate at the same time.
Skip the wait for peripherals that have already enumerated, avoiding
unnecessary delay when all peripherals are present.

…peripherals

Wait for each SoundWire peripheral's enumeration to complete instead of
assuming that all peripherals enumerate at the same time.
Skip the wait for peripherals that have already enumerated, avoiding
unnecessary delay when all peripherals are present.

Signed-off-by: Bard Liao <[email protected]>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The enumeration shortcut checks dev_num_sticky before enumeration completes, bypassing the wait and potentially including a peripheral whose device-number programming later fails.

1 open issue
What changed in this PR

This PR updates SOF Intel machine selection to wait for individual SoundWire peripherals rather than assuming all devices on a link enumerate together.

Changes:

  • Wait on each peripheral’s enumeration completion, with a fast path for devices considered already enumerated.
  • Remove bus-level enumeration completion and presence tracking.
File Description
sound/​soc/​sof/​intel/​hda.c Switches machine-selection waits and presence warnings to individual peripherals.
include/​linux/​soundwire/​sdw.h Removes bus-level enumeration and presence fields and their documentation.
drivers/​soundwire/​bus.c Removes initialization and signaling of the deleted bus-level state.

Review effort: Balanced

Comment thread sound/soc/sof/intel/hda.c Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants