Repository navigation
Conversation
…resent" This reverts commit dac6cca.
…peripherals Wait for each SoundWire peripheral's enumeration to complete instead of assuming that all peripherals enumerate at the same time. Skip the wait for peripherals that have already enumerated, avoiding unnecessary delay when all peripherals are present. Signed-off-by: Bard Liao <[email protected]>
bardliao
requested review from
jack-cy-yu,
oder-chiou and
shumingfan
as code owners
November 4, 2026 00:21
There was a problem hiding this comment.
🟡 Changes recommended
The enumeration shortcut checks dev_num_sticky before enumeration completes, bypassing the wait and potentially including a peripheral whose device-number programming later fails.
1 open issue
What changed in this PR
This PR updates SOF Intel machine selection to wait for individual SoundWire peripherals rather than assuming all devices on a link enumerate together.
Changes:
- Wait on each peripheral’s enumeration completion, with a fast path for devices considered already enumerated.
- Remove bus-level enumeration completion and presence tracking.
| File | Description |
|---|---|
sound/soc/sof/intel/hda.c |
Switches machine-selection waits and presence warnings to individual peripherals. |
include/linux/soundwire/sdw.h |
Removes bus-level enumeration and presence fields and their documentation. |
drivers/soundwire/bus.c |
Removes initialization and signaling of the deleted bus-level state. |
Review effort: Balanced
ujfalusi
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wait for each SoundWire peripheral's enumeration to complete instead of
assuming that all peripherals enumerate at the same time.
Skip the wait for peripherals that have already enumerated, avoiding
unnecessary delay when all peripherals are present.