TINYINT-3455: Update details - #79
Merged
Merged
Conversation
tiny-ben-tran
marked this pull request as ready for review
September 25, 2026 02:38
tiny-ben-tran
requested review from
a team,
MitchC1999,
TheSpyder,
hamza0867,
shanmen-tiny,
soritaheng and
spocke
and removed request for
a team
September 25, 2026 02:38
metricjs
approved these changes
Sep 25, 2026
metricjs
approved these changes
Sep 30, 2026
ArvinJ-H
reviewed
Oct 2, 2026
ArvinJ-H
left a comment
ArvinJ-H
left a comment
There was a problem hiding this comment.
Two ticket items are still open: the CONTRIBUTING.md rename and the Apache header in ScriptLoader.ts. I couldn't open the Notion template linked from the epic (it returns 404 for me), so I haven't checked the files against it.
src/main/ts/utils/ScriptLoader.ts lines 1 to 7 still say the source is under the Apache 2 license. Since the ticket asks for no Apache claims to remain, should this PR remove that header like tinymce/tinymce-angular#467 and tinymce/tinymce-vue#497 do?
The README in the published 2.4.0 package still says Apache 2.0, and the MIT fix from #78 is only on main. Is a patch release planned with this ticket so the npm page shows the right license?
ArvinJ-H
approved these changes
Oct 2, 2026
shanmen-tiny
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tickets: TINYINT-3455
Description of changes:
contributing.mdtoCONTRIBUTING.md