Repository navigation
State the integer domain of FloorCount - #245
Open
Qian-Cheng-nju wants to merge 1 commit into
Open
Qian-Cheng-nju wants to merge 1 commit into
Qian-Cheng-nju wants to merge 1 commit into
Conversation
Signed-off-by: Qian-Cheng-nju <[email protected]>
lemmy
reviewed
Oct 21, 2026
| Elevator, \* The set of all elevators | ||
| FloorCount \* The number of floors serviced by the elevator system | ||
|
|
||
| ASSUME FloorCountIsInteger == FloorCount \in Int |
Member
There was a problem hiding this comment.
@Qian-Cheng-nju Shouldn't Int be replaced with Nat \ {0}, given that the set of valid floors is defined as Floor == 1 .. FloorCount?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FloorCountis used inFloor == 1..FloorCount, but its domain is not stated. For example,FloorCount = TRUEis not excluded by an assumption; TLC then fails while evaluating the interval during initialization.Add
ASSUME FloorCountIsInteger == FloorCount \in Int. This states the domain needed by the interval and movement arithmetic. It adds neither a positivity requirement nor an upper bound, and leaves the actions and invariants unchanged.The shipped
ElevatorSafetySmallandElevatorLivenessMediummodels pass before and after the change with the same 4,122 distinct states. Parameter checks accept zero, negative and large integers, and reject the Boolean value at assumption evaluation. Two focused TLAPS lemmas also check that moving one floor toward an integer destination stays inFloor(six obligations,--strict --nofp).