Repository navigation
#209 Collapse SignTransitionResolver's triplicated join/leave logic - #215
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only non-blocking documentation and comment nits remain.
Pull request overview
This PR consolidates triplicated line, shape, and extrude join/leave handling into shared parameterized implementations without behavior changes.
Changes:
- Adds a shared
GroupResolverabstraction. - Preserves existing thresholds and fill-color behavior.
- Updates related architecture, testing, and verification documentation.
Review notes:
- Nit (1 vote): Update
core-pipeline.mdto describe the shared parameterized resolver consistently. - Nit (2 votes): Fix malformed emphasis markup in
SignTransitionResolver.java.
File summaries
| File | Description |
|---|---|
src/main/java/com/tpwalke2/bluemapsignmarkers/core/signs/SignTransitionResolver.java |
Shared multi-point join/leave implementation |
agent-context/README.md |
Updated verification metadata |
agent-context/context/testing.md |
Updated testing documentation |
agent-context/context/core-pipeline.md |
Updated transition-pipeline documentation |
Review details
Suppressed comments (1)
agent-context/context/core-pipeline.md:193
- The new paragraph describes the consolidation, but the table introduction above still says these types duplicate the pattern “rather than generalizing it.” That now contradicts the documented implementation and can mislead readers; update the introduction to describe the shared parameterized resolver instead.
are the single generic implementation behind all three `LINE`/`SHAPE`/`EXTRUDE` cells above — collapsed from three
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Collapses
SignTransitionResolver's triplicated line/shape/extrude join and leave logic into one parameterized implementation each.Why
lineJoinAction/lineLeaveAction,shapeJoinAction/shapeLeaveAction, andextrudeJoinAction/extrudeLeaveActionwere near-identical, differing only in group resolver, member threshold, and whether fill color applies. Tickets 01-03 already consolidated the action classes and factory methods these dispatch to, making the triplication removable without behavior change (.scratch/marker-action-consolidation/issues/05-collapse-signtransitionresolver-join-leave.md).Changes
GroupResolverfunctional interface matchingLineGroupResolver/ShapeGroupResolver/ExtrudeGroupResolver's sharedmembers(...)signaturemultiPointJoinAction/multiPointLeaveAction, parameterized by resolver, minimum-member threshold, andMarkerGroupTypekindhasFill(MarkerGroupType)to gate fill-color resolution (LINE has none; SHAPE/EXTRUDE do)leaveEffect/joinEffect's switch arms to call the new parameterized methods with method references (LineGroupResolver::members, etc.)Testing
./gradlew test --tests "*.SignTransitionResolverTest"— existing coverage of line/shape/extrude join/leave transitions passes unmodified./gradlew buildpasses